Bug 413585

Summary:	kde-base/kdm-4.8.2: patch to correct path to grub2
Product:	Gentoo Linux	Reporter:	Egor Y. Egorov <egorov_egor>
Component:	[OLD] KDE	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dschridde+gentoobugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	kdm-4.8.2-grub2_support.patch

Description Egor Y. Egorov 2012-04-26 03:51:15 UTC

In Gentoo grub2 tools are labeled 2 (grub2-*). However, in the kdm code hard-coded path without 2. Attached patch solves this problem.

Reproducible: Always

Comment 1 Egor Y. Egorov 2012-04-26 03:51:39 UTC

Created attachment 310133 [details]
kdm-4.8.2-grub2_support.patch

Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev

2012-04-26 10:37:27 UTC

Ack by me

Comment 3 Johannes Huber (RETIRED) gentoo-dev

2012-04-26 11:11:17 UTC

Thank you, patch committed.

+  26 Apr 2012; Johannes Huber <johu@gentoo.org> +files/kdm-4.8.2-grub2.patch,
+  +kdm-4.8.2-r1.ebuild:
+  Add patch to fix grub:2 support by Egor Y. Egorov <egorov_egor@bk.ru> wrt bug
+  #413585.

Comment 4 Dennis Schridde 2012-05-10 15:36:11 UTC

I just found this in my logs:
kdm[2315]: Cannot execute 'grub-reboot': not in $PATH.

That is using kde-base/kdm-4.8.3 - any idea what is wrong here?

Comment 5 Michael Palimaka (kensington) gentoo-dev

2012-05-10 16:23:47 UTC

(In reply to comment #4)
> I just found this in my logs:
> kdm[2315]: Cannot execute 'grub-reboot': not in $PATH.
> 
> That is using kde-base/kdm-4.8.3 - any idea what is wrong here?

In 4.8.3, an extended version of this patch was accepted upstream - it detects what to do at runtime.

Can you confirm that /boot/grub2/grub.cfg exists?

Comment 6 Dennis Schridde 2012-05-10 17:57:00 UTC

(In reply to comment #5)
> Can you confirm that /boot/grub2/grub.cfg exists?
/boot is on a separate partition. On that partition the file exists, but not during regular runtime.

Comment 7 Michael Palimaka (kensington) gentoo-dev

2012-05-10 19:54:44 UTC

(In reply to comment #6)
> /boot is on a separate partition. On that partition the file exists, but not
> during regular runtime.

I believe grub2-reboot requires /boot to be mounted in order to work - it writes to /boot/grub2/grubenv with the entry to use on next reboot.

Comment 8 Dennis Schridde 2012-05-10 20:04:21 UTC

(In reply to comment #7)
> (In reply to comment #6)
> > /boot is on a separate partition. On that partition the file exists, but not
> > during regular runtime.
> 
> I believe grub2-reboot requires /boot to be mounted in order to work - it
> writes to /boot/grub2/grubenv with the entry to use on next reboot.

So what do you suggest? Fixing grub-reboot to automatically mount /boot?

Comment 9 Michael Palimaka (kensington) gentoo-dev

2012-05-11 16:50:58 UTC

(In reply to comment #8)
> So what do you suggest? Fixing grub-reboot to automatically mount /boot?
I am not sure that auto-mounting is such a good idea, but I don't really know what to suggest.

Comment 10 Johannes Huber (RETIRED) gentoo-dev

2012-05-11 19:31:15 UTC

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > /boot is on a separate partition. On that partition the file exists, but not
> > > during regular runtime.
> > 
> > I believe grub2-reboot requires /boot to be mounted in order to work - it
> > writes to /boot/grub2/grubenv with the entry to use on next reboot.
> 
> So what do you suggest? Fixing grub-reboot to automatically mount /boot?

I would suggest to just change your mount options for /boot partition in /etc/fstab. I tested the kdm integration with 4.8.3 and it works like a charm yesterday. Greetings.