Bug 413105 – media-sound/banshee-2.4.0-r1: Rename USE="ios" to more correct USE="ipod" for pulling libgpod[mono] in

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Daniel Klaffenbach 2012-04-22 15:52:59 UTC]

Setting USE="-ios" disables support for all Apple media devices, including the ones not running iOS (like iPod Classic/Nano/Shuffle/...).

On the other hand USE="ios" pulls in dependencies such as app-pda/libimobiledevice which is not required for accessing non-iOS iPods.

Version 2.2.0 of the media-sound/banshee ebuild supported the plain old "ipod" USE-flag, which only pulled in libgpod as a dependency. From a user point of view this seems like a far better option.

[Comment 1 Samuli Suominen (RETIRED) 2012-04-22 16:29:14 UTC]

Created attachment 309795 [details, diff]
Patch for banshee-2.4.0-r1.ebuild

This looks more correct to me too. 

I'm not sure why the ebuild had gnome-base/gvfs[ios] in the dependencies at all. It's not banshee's business to check for this. 
Unless it's really required? 
Can you test ipod support with this patch, and gnome-base/gvfs built with USE="-ios"?

[Comment 2 Daniel Klaffenbach 2012-04-22 18:23:37 UTC]

Thanks for the patch. I've applied it (had to remove one closing bracket in the ebuild) and Banshee now supports my iPod with USE="ipod -ios". I was also able to remove libimobiledevice and friends - it did not have any effects on Banshee's iPod support.

AFAIK Banshee also uses libgpod for accessing iOS-devices (libgpod[ios] required). This would mean pulling in libimobiledevice is not up to Banshee, which I would consider correct behavior.

[Comment 3 Samuli Suominen (RETIRED) 2012-04-22 18:29:04 UTC]

(In reply to comment #2)
> Thanks for the patch. I've applied it (had to remove one closing bracket in
> the ebuild) and Banshee now supports my iPod with USE="ipod -ios". I was
> also able to remove libimobiledevice and friends - it did not have any
> effects on Banshee's iPod support.
> 
> AFAIK Banshee also uses libgpod for accessing iOS-devices (libgpod[ios]
> required). This would mean pulling in libimobiledevice is not up to Banshee,
> which I would consider correct behavior.

Applied the patch (without the bracket) in Portage. Thanks for testing.

Yeah, to get IOS support users really need to set USE="ios" and emerge world with --newuse, it's not banshees business to force it

http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/banshee/banshee-2.4.0-r1.ebuild?r1=1.2&r2=1.3

[Comment 4 Pacho Ramos 2012-04-23 09:26:03 UTC]

Did you check this change with leio? I think I moved to ios after talking with him on IRC, and gvfs[ios] was needed for some reason... but I don't remember the exact problem (I don't even have any apple hardware)

[Comment 5 Samuli Suominen (RETIRED) 2012-04-23 09:45:40 UTC]

(In reply to comment #4)
> Did you check this change with leio? I think I moved to ios after talking
> with him on IRC, and gvfs[ios] was needed for some reason... but I don't
> remember the exact problem (I don't even have any apple hardware)

No, I didn't check with other than the user reporting here. 

Sure, if he has an iDevice, like iPod with iOS on it, then he would need gvfs built with USE=ios, and sure, that will affect banshee indirectly too.

However, that doesn't mean banshee should be forcing it or dealing with it... It's a gvfs feature that should be controlled by USE flags in gvfs itself.