Bug 411281

Summary:	x11-proto/xcb-proto-1.7.1 should use EAPI 4 to detect upgrades
Product:	Gentoo Linux	Reporter:	Petteri Räty (RETIRED) <betelgeuse>
Component:	[OLD] Library	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	pacho
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Petteri Räty (RETIRED) gentoo-dev

2012-04-08 16:03:22 UTC

* Please rebuild both libxcb and xcb-util if you are upgrading from version 1.6

With EAPI 4 you can detect if this is the case using REPLACING_VERSIONS

Comment 1 Pacho Ramos gentoo-dev

2013-10-06 17:31:17 UTC

I will commit it next week if nobody disagree

Thanks

Comment 2 Rémi Cardona (RETIRED) gentoo-dev

2013-10-07 19:07:22 UTC

Got a patch we can look at?

Comment 3 Pacho Ramos gentoo-dev

2013-10-07 19:32:56 UTC

Would be the following:
--- xcb-proto-1.8-r3.ebuild~	2013-10-07 07:01:40.000000000 +0200
+++ xcb-proto-1.8-r3.ebuild	2013-10-07 21:31:33.000000000 +0200
@@ -43,5 +43,7 @@
 }
 
 pkg_postinst() {
-	ewarn "Please rebuild both libxcb and xcb-util if you are upgrading from version 1.6"
+	if [[ ${REPLACING_VERSIONS} < 1.7 ]]; then
+		ewarn "Please rebuild both libxcb and xcb-util if you are upgrading from version 1.6"
+	fi
 }

Comment 4 Rémi Cardona (RETIRED) gentoo-dev

2013-10-07 19:54:23 UTC

Looks ok to me.

@x11, any objections?

Comment 5 Chí-Thanh Christopher Nguyễn gentoo-dev

2013-10-07 19:55:37 UTC

I am not sure if that works, because e.g. [[ 1.10 < 1.7 ]] will evaluate to true, and REPLACING_VERSIONS can contain multiple versions.

Maybe something with has() would be better.

Comment 6 Pacho Ramos gentoo-dev

2013-10-07 20:22:16 UTC

Yeah, I have tried to find some way to handle this but I couldn't :S, I have seen in the tree some ways like relying in versionator eclass for this (used, for example, in postfix ebuilds)

Comment 7 Ian Delaney (RETIRED) gentoo-dev

2014-11-24 08:36:37 UTC

purged from portage