Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 411265

Summary: media-gfx/swftools: version bump request
Product: Gentoo Linux Reporter: Pacho Ramos <pacho>
Component: New packagesAssignee: László Szalma <dblaci>
Status: RESOLVED FIXED    
Severity: enhancement CC: alecm_88, pacho, poncho
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 337239, 350609    
Attachments: swftools-20120224
nopdf.patch
swftools-0.9.2_nopdf
swftools-0.9.2_nopdf.patch
swftools-0.9.2_general.patch
swftools-0.9.2.ebuild
swftools-0.9.2_general.patch
swftools-0.9.2_nopdf.patch
swftools-0.9.2_general.patch

Description Pacho Ramos gentoo-dev 2012-04-08 11:36:43 UTC
This will be used to track swftools readdition with a new and fixed version

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2012-04-08 11:37:50 UTC
The idea is to ensure all existing swftools bugs are solved with this bump, will add them as depending on this one, please check they are solved, also, attach here your updated ebuild+patches

Thanks :)
Comment 2 László Szalma 2012-04-08 17:11:45 UTC
Created attachment 308227 [details]
swftools-20120224
Comment 3 László Szalma 2012-04-08 17:14:16 UTC
Created attachment 308229 [details, diff]
nopdf.patch

With this ebuild and the patch the current development snapshot builds, except the pdf2swf.
Comment 4 László Szalma 2012-04-09 18:29:15 UTC
Created attachment 308327 [details, diff]
swftools-0.9.2_nopdf
Comment 5 László Szalma 2012-04-09 18:29:53 UTC
Created attachment 308329 [details, diff]
swftools-0.9.2_nopdf.patch
Comment 6 László Szalma 2012-04-09 18:31:33 UTC
Created attachment 308331 [details, diff]
swftools-0.9.2_general.patch

this patch fixes swfs symlnik and a mistake in png2swf.c that caused warning (and segfault)
Comment 7 László Szalma 2012-04-09 18:32:38 UTC
Created attachment 308333 [details]
swftools-0.9.2.ebuild

version bump
Comment 8 Pacho Ramos gentoo-dev 2012-04-09 18:58:37 UTC
Keep it opened until I have time to commit the ebuild
Comment 9 Pacho Ramos gentoo-dev 2012-04-11 08:20:14 UTC
Can you provide uniffied patches? They are preferred and you simply need to use "-u" diff option

Thanks :)
Comment 10 László Szalma 2012-04-11 19:44:01 UTC
Created attachment 308557 [details, diff]
swftools-0.9.2_general.patch
Comment 11 László Szalma 2012-04-11 19:44:25 UTC
Created attachment 308559 [details, diff]
swftools-0.9.2_nopdf.patch

unified version
Comment 12 Pacho Ramos gentoo-dev 2012-04-15 09:50:40 UTC
(In reply to comment #10)
> Created attachment 308557 [details, diff] [details, diff]
> swftools-0.9.2_general.patch

This patch makes it to try to run "ln -s -r" what looks to be not supported on stable systems:

/usr/bin/install -c -m 644 ./swft_loader.swf /var/tmp/portage/media-gfx/swftools-0.9.2/image/usr/share/swftools/swfs/swft_loader.swf
ln -s -r /var/tmp/portage/media-gfx/swftools-0.9.2/image/usr/share/swftools/swfs/simple_viewer.swf /var/tmp/portage/media-gfx/swftools-0.9.2/image/usr/share/swftools/swfs/default_viewer.swf
ln: opción inválida -- 'r'
Pruebe `ln --help' para más información.
make[1]: *** [install] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-gfx/swftools-0.9.2/work/swftools-0.9.2/swfs'
make: *** [install] Error 2

Are you sure it is not a mistake?
Comment 13 László Szalma 2012-04-15 10:13:46 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > Created attachment 308557 [details, diff] [details, diff] [details, diff]
> > swftools-0.9.2_general.patch
> 
> This patch makes it to try to run "ln -s -r" what looks to be not supported
> on stable systems:
> 
> /usr/bin/install -c -m 644 ./swft_loader.swf
> /var/tmp/portage/media-gfx/swftools-0.9.2/image/usr/share/swftools/swfs/
> swft_loader.swf
> ln -s -r
> /var/tmp/portage/media-gfx/swftools-0.9.2/image/usr/share/swftools/swfs/
> simple_viewer.swf
> /var/tmp/portage/media-gfx/swftools-0.9.2/image/usr/share/swftools/swfs/
> default_viewer.swf
> ln: opción inválida -- 'r'
> Pruebe `ln --help' para más información.
> make[1]: *** [install] Error 1
> make[1]: Leaving directory
> `/var/tmp/portage/media-gfx/swftools-0.9.2/work/swftools-0.9.2/swfs'
> make: *** [install] Error 2
> 
> Are you sure it is not a mistake?

Strange. ln -r should make relative symlink. Is this a new feature of ln or what?

If it don't craete relative then the portage breaks it...

I can't do anything else, I temporary remove those symlinks, they are connected to pdf anyway.
Comment 14 László Szalma 2012-04-15 10:19:27 UTC
Created attachment 309023 [details, diff]
swftools-0.9.2_general.patch

ln -r is not supported in stable, removing symlinks for this time.
Comment 15 Pacho Ramos gentoo-dev 2012-04-15 10:39:01 UTC
Will probably use "ln -s -r" patch as it's more future proof, I am updating my coreutils now to test
Comment 16 Pacho Ramos gentoo-dev 2012-04-15 10:50:23 UTC
+*swftools-0.9.2 (15 Apr 2012)
+
+  15 Apr 2012; Pacho Ramos <pacho@gentoo.org>
+  +files/swftools-0.9.2_general.patch, +files/swftools-0.9.2_nopdf.patch,
+  +metadata.xml, +swftools-0.9.2.ebuild:
+  Reintroduce media-gfx/swftools as people demanded it, upstream released a new
+  version and now is proxy maintained. Thanks a lot to László Szalma (bug
+  #411265).
+
Comment 17 Alec Meyers 2012-04-16 18:36:56 UTC
Thanks for the nice work, László!