Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 410565

Summary: xfburn-4.3-r3 will not compile against xfce4.10-pre (unmasked for testing) (fix in bug body)
Product: Gentoo Linux Reporter: Derk W te Bokkel <derk.tebokkel>
Component: Current packagesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 406437    
Attachments: build.log
xfburn-settings-glib-object-include.patch
xfburn-settings-glib-gobject-include.patch
xfburn-0.4.3-r1.ebuild

Description Derk W te Bokkel 2012-04-02 14:21:02 UTC
Created attachment 307491 [details]
build.log

while doing testing of newest xfce4 prerelease found that xfburn-4.3-r3 does not compile .. fails in xfburn-settings.c/xfburn-settings.h  

build log attached .. 


I suspect missing  header info but i am not sure..?
Comment 1 Derk W te Bokkel 2012-04-02 16:02:13 UTC
FYI

a previously built version of xfburn-4.3-r3  will run against libxfce4util.so.6.0.0 if a symlink is added that fakes libxfce4util.so.4 and actually linked to libxfce4util.so.6.0.0

So a define/header issue seems to be the problem .. although no functionality was tested so far .. I'm just clue hunting ..
Comment 2 Derk W te Bokkel 2012-04-02 17:56:46 UTC
okay trying to burn a disk does not work as the disk is not detected by xfburn or so it appears other software works fine and it previously worked so some function is missing/disabled by the lib-upgrade and loss of xfce-utils maybe?
Comment 3 Derk W te Bokkel 2012-04-02 21:06:05 UTC
okay adding the following line after the glib.h include  
#include <glib-object.h>
to the xfbrun-settings.h file allows the build to proceed to completion.

now to test functionality :)
Comment 4 Derk W te Bokkel 2012-04-02 21:40:59 UTC
Created attachment 307555 [details, diff]
xfburn-settings-glib-object-include.patch

adding the change in this patch to the build allows xfburn to build and run .. at least it burns an iso to cd .. all that was tested.
Comment 5 Derk W te Bokkel 2012-04-02 22:02:29 UTC
Created attachment 307557 [details, diff]
xfburn-settings-glib-gobject-include.patch

replace with one that has the directory structure
Comment 6 Derk W te Bokkel 2012-04-02 22:03:41 UTC
Created attachment 307559 [details]
xfburn-0.4.3-r1.ebuild

an ebuild with the patch in place
Comment 7 Derk W te Bokkel 2012-04-02 22:54:43 UTC
someone want to add this fix to the tree
Comment 8 Derk W te Bokkel 2012-04-02 22:57:13 UTC
oops I see i'm dislexic again .. xfbrun-0.4.3-r4.ebuild is what I intended
Comment 9 Derk W te Bokkel 2012-04-02 23:18:55 UTC
I see that gobject dependancy was removed from >=libxfce4util-4.9.0 but xfburn requires glib-object hence the bug .. easy fix .. so it appears but perhaps a condtional test in the build for the newer libxfce4util version might be necessary in the short term but .. maybe not ? anyone care to new ebuild check against 4.8 version library?
Comment 10 Derk W te Bokkel 2012-04-03 10:58:09 UTC
actually no extra test is required .. builds and runs fine with the xfburn-settings-glib-object-patch against 4.8 libraries ..
so new xfburn-0.4.3-r4 ebuild can be used as is for both 4.8 and 4.10 versions
(at least on amd64)/~amd64)
Comment 11 Derk W te Bokkel 2012-04-03 12:28:51 UTC
fixed added to tree by ssuominen  apr 3 2012