Summary: | www-plugins/adobe-flash-11.2, <=x11-libs/libvdpau-0.4.1-r1: incorrect colors when playing flash on Youtube | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Oschtan <dawnstyle> |
Component: | Current packages | Assignee: | Jim Ramsay (lack) (RETIRED) <lack> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ainsaar, axton.malsbury, cardoe, damien.thebault, dark.knight.ita, ezelspinguin, gentoo-bugs, gentoo, jalanpalmer, krinpaus, krzysiekcybura, larkang, marienz, matt, mike, mr_bones_, netbox253, p, poncho, publiosulpicio, serkan, SuloevDmitry, szalkai, tetromino, thatslyude, tom, xman00 |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugbase.adobe.com/index.cfm?event=bug&id=3109467 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
libvdpau_flashplayer.patch from debian
vdpau_wrapper.c: Track dynamic library handles and free them on exit using __attribute__((destructor)) |
Description
Oschtan
2012-04-01 13:22:56 UTC
This a problem for users of nvidia-drivers. Nvidia[1] and Adobe[2] blame each other. Supposedly a workaround exists in libvdpau from git. [1] http://www.nvnews.net/vbulletin/showthread.php?t=177380 [2] https://bugbase.adobe.com/index.cfm?event=bug&id=3109467 Here’s the link to the workaround: http://www.nvnews.net/vbulletin/showpost.php?p=2518770&postcount=104 Please include it into the ebuild. Thanks. (In reply to comment #1) > This a problem for users of nvidia-drivers. Nvidia[1] and Adobe[2] blame > each other. Supposedly a workaround exists in libvdpau from git. > > [1] http://www.nvnews.net/vbulletin/showthread.php?t=177380 > [2] https://bugbase.adobe.com/index.cfm?event=bug&id=3109467 Downgrading to Flash version 11.1.102.63 works OK, then isn't a vdpau problem: is a flash problem. (In reply to comment #3) > Downgrading to Flash version 11.1.102.63 works OK, then isn't a vdpau > problem: is a flash problem. I think I have to disagree, since before Flash 11.2, it would not scale the video in full-screen, and stuttered at everything above 480p. Now it runs completely fluid at full-screen with full HD (1920×1080). So as far as I can tell, there was no actual acceleration before 11.2 (at least on nVidia). Obviously, I very much like to keep the acceleration. :) So going back to an older Flash is not an option. There’s no harm in trying to just add the workaround that I posted in comment #2. :) *** Bug 411379 has been marked as a duplicate of this bug. *** (In reply to comment #4) > There’s no harm in trying to just add the workaround that I posted in > comment #2. :) That's a ghetto fix that hijacks VDPAU_TRACE for a different purpose and disables other customization hooks. Something like that should be a last resort. FWIW, my video has been fluid at full-screen 1080p since (and including) 11.1. It sure feels like hardware acceleration is working, but I could be mistaken. (In reply to comment #6) > That's a ghetto fix that hijacks VDPAU_TRACE for a different purpose and > disables other customization hooks. Something like that should be a last > resort. Alright. In that case, that’s of course correct. :) > FWIW, my video has been fluid at full-screen 1080p since (and including) > 11.1. It sure feels like hardware acceleration is working, but I could be > mistaken. No, sorry. I just downgraded to 11.1, to make sure. And indeed, it stops scaling. In “full-screen”, it’s the video is just a ⅓ of the height and width of the screen in size. While stuttering a lot. Definitely not accelerated. Ran into the same problem. Adding EnableLinuxHWVideoDecode=1 to /etc/adobe/mms.cfg fixed the problem. (In reply to comment #8) > EnableLinuxHWVideoDecode=1 > to /etc/adobe/mms.cfg fixed the problem. Thanks. That helped. I now have fullscreen accelerated HD with the correct colors. But Flash then crashed four times over the course of 20 minutes. (Not very bad for YouTube, where I tested it. But it would be bad for Kongregate, when one would lose game state.) Which may explain why it’s not set by default, and not even listed a existing property to set in the comments. But my assumption is, that this is a bug in how Flash uses the VDPAU interface. So I don’t really know how to proceed. (Except for abandoning all Flash for browser-native technology, of course. :) *** Bug 412785 has been marked as a duplicate of this bug. *** (In reply to comment #8) > Ran into the same problem. > Adding > EnableLinuxHWVideoDecode=1 > > to /etc/adobe/mms.cfg fixed the problem. When you close Google Chrome tabs with Flash from Youtube where EnableLinuxHWVideoDecode=1 is the X-server hang. It is fatal. Adjourn the X-server can only remotely: keyboard and mouse are inoperable (In reply to comment #11) > (In reply to comment #8) > > Ran into the same problem. > > Adding > > EnableLinuxHWVideoDecode=1 > > > > to /etc/adobe/mms.cfg fixed the problem. > > When you close Google Chrome tabs with Flash from Youtube where > EnableLinuxHWVideoDecode=1 is the X-server hang. It is fatal. Adjourn the > X-server can only remotely: keyboard and mouse are inoperable For Flash-11.2x There is at least one report that the latest version of flash improves some of the colour issues. Please give it a shot and report back here. www-plugins/adobe-flash-11.2.202.233 P.S. Remember to unset EnableLinuxHWVideoDecode=1 if you have previously done so to workaround this bug. (In reply to comment #13) > There is at least one report that the latest version of flash improves some > of the colour issues. Please give it a shot and report back here. > > www-plugins/adobe-flash-11.2.202.233 > > P.S. Remember to unset EnableLinuxHWVideoDecode=1 if you have previously > done so to workaround this bug. Still blue people everywhere. The solution that worked for me is as follows (although with the price of no hardware acceleration, but it does not bother me much). Firstly I added "EnableLinuxHWVideoDecode = 0" into /etc/adobe/mms.cfg . I tried a "1" there, but this way vimeo.com did not work. Secondly I opened a Youtube video showing the "blue people" (NB! Not every video is like that, HTML5 has always been working), made it full-screen (otherwise the settings dialog would hang), right-clicked, chose "Settings" and then disabled hardware acceleration. Escaped from the full-screen mode and reloaded the page - done! (In reply to comment #15) > (NB! Not every video is like that, HTML5 has always been working), Well, this is a Flash problem, so obviously, HTML5 is fine. The problem can be broken down like this: • Every accelerated YouTube Flash video is like that. • When they are embedded in other pages, they are not like that, but there is also no acceleration. • For others, like Vimeo or porn sites, I don’t know if they are accelerated, but they always look fine, no matter if embedded or not. Created attachment 314577 [details, diff] libvdpau_flashplayer.patch from debian [VDPAU] [PATCH] Implement workarounds for Adobe Flash bugs http://lists.freedesktop.org/archives/vdpau/2012-May/000022.html (In reply to comment #17) > Created attachment 314577 [details, diff] [details, diff] > libvdpau_flashplayer.patch from debian This works by looking at the /proc/self/cmdline file. With chrome, this will work because the flash plugin is executed in a specific process with this as parameter: "--type=plugin --plugin-path=/usr/lib/flashplugin-installer/libflashplayer.so". But I'm wondering, does it work on Firefox? It would maybe be better to look for a "libflashplayer" entry in the /proc/self/maps file ? (In reply to comment #18) > But I'm wondering, does it work on Firefox? Yes, Firefox also uses a separate process. The line looks like this: /usr/lib64/firefox/plugin-container /opt/Adobe/flash-player/flash-plugin/libflashplayer.so -greomni /usr/lib64/firefox/omni.ja 5486 false plugin > It would maybe be better to look for a "libflashplayer" entry in the > /proc/self/maps file ? Yes, the patch sounds really messy. But this is not really better. The debian patch doesn't apply correctly? The final hunk fails since it is beyond the end of the file. Seems it is for a different version than 0.4.1? Created attachment 315287 [details, diff] vdpau_wrapper.c: Track dynamic library handles and free them on exit using __attribute__((destructor)) (In reply to comment #20) > The debian patch doesn't apply correctly? The final hunk fails since it is > beyond the end of the file. Seems it is for a different version than 0.4.1? You need to apply the latest commit from git as well. http://cgit.freedesktop.org/~aplattner/libvdpau/commit/?id=4262513e67c3572ed19bd796ec6180cdde7ccb7e Just curious: What is the actual problem here? Shouldn’t this just be a case of removing the swapping the red and blue bytes in the function using or implementing an interface? I just updated to Flash 11.2.202.236, and this got even worse: Now it seems like the colors are completely inverted or something. I have videos where white is black, etc. Same problem on latest xf86-video-ati and mesa with vdpau. After applying both patches libvdpau failed to build. To fix it on line 334 you need delete first argument. (In reply to comment #25) > To fix it on line 334 you need delete first argument. ... in fopen function call. I think here is another try by using a wrapper.cfg: http://lists.freedesktop.org/archives/vdpau/2012-May/000022.html Testing with 1. x11-drivers/nvidia-drivers-304.37 2. www-plugins/adobe-flash-11.2.202.238 3. www-client/google-chrome-21.0.1180.79_p151411 4. www-client/opera-12.01.1532 I thought newest nvidia would obsolete vdpau patch of my comment27 but: 3. google-chrome-21 using pepperflash displays correct colors. This inside google pepperflash doesn't respect /etc/adobe/mms.cfg 4. inside opera newest Adobe flash with - /etc/adobe/mms.cfg unchanged displays blue faces on youtube - enabling these changes inside mms.cfg work, displays natural colors: AllowUserLocalTrust = 0 AssetCacheSize = 32 AutoUpdateDisable = 1 AVHardwareDisable = 1 DisableDeviceFontEnumeration = 1 DisableProductDownload = 1 DisableSockets = 0 EnableSocketsTo = 127.0.0.1 FullScreenDisable = 1 LocalStorageLimit = 5 OverrideGPUValidation = 1 WindowlessDisable = 1 EnableLinuxHWVideoDecode = 1 (In reply to comment #28) > OverrideGPUValidation = 1 As mentioned and tested before, this causes crashes of Flash. (About every 2nd to 3rd video in my case.) The validation is probably there for a reason. @Navid, yes better validation is done, does crash otherwise sometimes ... Step one: Comment out crap added to mms.cfg # Lets you override GPU validation checks to force hardware acceleration # Warning: This may make your player (more) unstable! # 0 = Check GPU (default), 1 = Skip checks # More details: # http://blogs.adobe.com/penguin.swf/2008/08/secrets_of_the_mmscfg_file_1.html #OverrideGPUValidation = 1 #EnableLinuxHWVideoDecode = 0 #AVHardwareDisable = 0 Step two: Re-enable HW accel rm ~/.macromedia/Flash_Player/macromedia.com/support/flashplayer/sys/settings.sol Step three: Install patched libvdpau https://suigintou.weedy.ca/trac/gentoo-overlay/changeset/36 Done. @Weedy is this the patch applied of freedesktop.org mentioned in #27 ? (In reply to comment #31) > Step one: Comment out crap added to mms.cfg Since people very likely will not really know what they originally changed, it’s probably best, to just run cat /usr/portage/www-plugins/adobe-flash/files/mms.cfg > /etc/adobe/mms.cfg (I used cat instead of cp, to keep the permissions, groups, xattrs, etc.) Is it possible to push the libvdpau patch to portage with a USE flag (something like "fixflash")? libvdpau-0.5 in Portage with USE="dri" in case anyone wants to give it a try. (In reply to comment #35) > libvdpau-0.5 in Portage with USE="dri" in case anyone wants to give it a try. I'm using x11-libs/libvdpau-0.5 with USE="dri" and the "blue problem" has been solved. (In reply to comment #36) > I'm using x11-libs/libvdpau-0.5 with USE="dri" and the "blue problem" has > been solved. I can confirm that. Problem solved. Whoever did it: Many thanks!! :) My issue has also been resolved. Use >=x11-libs/libvdpau-0.5 with USE="dri" /me is now happy. :) |