Summary: | media-sound/pulseaudio: ebuild should suggest people to set SND_HDA_PREALLOC_SIZE to 2048 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pacho Ramos <pacho> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | alexander, kernel-misc, sound, tdalman, vikraman |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Pacho Ramos
2012-03-25 12:00:38 UTC
ping Umm, I don't know how to use linux-info.eclass to achieve this :S I added a check for CONFIG_SND_HDA_PREALLOC_SIZE >= 2048. The other issue is that calling linux-info_pkg_setup does the config check again in pkg_setup(). What do you want to do about that? Per eclass documentation looks like it was needed: # Before using any of the config-handling functions in this eclass, you must # ensure that one of the following functions has been called (in order of # preference), otherwise you will get bugs like #364041): # linux-info_pkg_setup # linux-info_get_any_version # get_version # get_running_version But maybe it's obsolete since I have seen all the options in the tree Hm, it does make more sense to check kernel config in pkg_pretend() instead of pkg_setup(), but I don't know why linux-info calls it pkg_setup(). Should this check be moved to pkg_setup() then? (In reply to Pacho Ramos from comment #4) > Per eclass documentation looks like it was needed: > # Before using any of the config-handling functions in this eclass, you must > # ensure that one of the following functions has been called (in order of > # preference), otherwise you will get bugs like #364041): > # linux-info_pkg_setup > # linux-info_get_any_version > # get_version > # get_running_version > > But maybe it's obsolete since I have seen all the options in the tree Heh.. Seems this check is taken from lvm2/systemd ebuilds. It was originally written by me for lvm2 ebuild [1]. I don't know why ssuominen chose to commit the first version of the patch. In the second version of the patch linux_chkconfig_string() is called after check_extra_config() which calls linux-info_get_any_version() internally. [1] https://bugs.gentoo.org/show_bug.cgi?id=479756 (In reply to Alexander Tsoy from comment #6) > In the second version of the patch > linux_chkconfig_string() is called after check_extra_config() which calls > linux-info_get_any_version() internally. btw, pulseaudio ebuild currently does exactly the same thing. So I assume everything should work fine. |