Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 409293

Summary: eutils.eclass - epatch ignores files
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: EclassesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED INVALID    
Severity: normal CC: kde, pyxlcy
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Toralf Förster gentoo-dev 2012-03-22 09:36:47 UTC 
I tried to back port a KGpg krash and therefore I putted the KDEs diff file into the directory /etc/portage/patches/kde-base/kgpg-4.8.1/ :
changeset_r42f8b1b51b09cb4b64fadf7e6cdd5ce359b0fa74.diff
But it was ignored. From the log file of portage :

>>> Preparing source in /var/tmp/portage/kde-base/kgpg-4.8.1/work/kgpg-4.8.1 ...
 * Applying user patches from /etc/portage/patches//kde-base/kgpg-4.8.1 ...
 * Done with patching
>>> Source prepared.


After I renamed it to 42f8b1b5.patch epatch worked well :

>>> Preparing source in /var/tmp/portage/kde-base/kgpg-4.8.1/work/kgpg-4.8.1 ...
 * Applying user patches from /etc/portage/patches//kde-base/kgpg-4.8.1 ...
 *   42f8b1b5.patch ...
 [ ok ]
 * Done with patching
>>> Source prepared.



Reproducible: Always
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-03-22 13:06:18 UTC 
I don't think the filename length is important here, but its format is, combined with some KDE related eclasses.
Comment 2 Richard Grenville 2012-03-22 13:21:24 UTC 
epatch_user() in eutils.eclass only applies patches whose names end with ".patch" (EPATCH_SUFFIX="patch"), so *.diff don't work.
Comment 3 Toralf Förster gentoo-dev 2012-03-22 13:42:56 UTC 
(In reply to comment #2)
> epatch_user() in eutils.eclass only applies patches whose names end with
> ".patch" (EPATCH_SUFFIX="patch"), so *.diff don't work.

Argh - is this documented (I didn't found anythign related to suffix restrictions here : http://www.gentoo.org/doc/en/handbook/handbook-amd64.xml?style=printable&part=3&chap=6#doc_chap6) ?
Nevertheless what's about adding ".diff" too to the suffix list - it is a common file suffix for such things, isn't it ?