Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 408497

Summary: sci-mathematics/4ti2-1.3.2-r1: gold patch breaks Darwin targets
Product: Gentoo/Alt Reporter: MATSUI Tetsushi <VED03370>
Component: Prefix SupportAssignee: Gentoo Prefix <prefix>
Status: RESOLVED FIXED    
Severity: enhancement CC: jlec
Priority: Normal    
Version: unspecified   
Hardware: x86   
OS: OS X   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 369849    
Bug Blocks:    
Attachments: modified gold patch

Description MATSUI Tetsushi 2012-03-16 13:57:36 UTC
Created attachment 305623 [details]
modified gold patch

I want 4ti2 on ~x86-macos environment, so this request.

These two packages need keyworded:
sci-mathematics/4ti2
sci-mathematics/glpk

Second, sci-mathematics/4ti2 need update a patch.
4ti2-1.3.2-gold.patch replaces "./libtool" with "libtool".  
But, on Gentoo prefix on OS X, it should be "glibtool",
since "libtool" refers non-GNU libtool provided by
sys-devel/binutils-apple that does not accept "--mode=link"
option, and "glibtool" is the one that is provided by
sys-devel/libtool.
I will attach a possible patch replacing the "gold" patch,
that checks the existence of glibtool and uses if exists.
Comment 1 Fabian Groffen gentoo-dev 2012-03-24 14:31:12 UTC
The gold patch does two things:

1) it fixes underlinking
2) it changes to using global libtool iso the bundled one

only 1) is documented.
@jlec mind to check if 2) is really necessary?  Would make fixing here just a whole lot less ugly.
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2012-03-25 09:43:46 UTC
+  25 Mar 2012; Justin Lecher <jlec@gentoo.org> 4ti2-1.3.2-r1.ebuild,
+  files/4ti2-1.3.2-gold.patch, metadata.xml:
+  Correct gold patch to fix build on Darwin targets, #408497
+

Hopefully it is fixed now. Please test
Comment 3 MATSUI Tetsushi 2012-03-25 15:52:24 UTC
(In reply to comment #2)
> +  25 Mar 2012; Justin Lecher <jlec@gentoo.org> 4ti2-1.3.2-r1.ebuild,
> +  files/4ti2-1.3.2-gold.patch, metadata.xml:
> +  Correct gold patch to fix build on Darwin targets, #408497
> +
> 
> Hopefully it is fixed now. Please test

Yes, 4ti2 compiles fine with the new patch and works for my tiny examples.
Thank you.