Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 408313

Summary: app-admin/conky-1.8.1 - patch to add plot dot graph option
Product: Gentoo Linux Reporter: Alessandro Di Marco <dmr>
Component: New packagesAssignee: Daniel Pielmeier <billie>
Status: RESOLVED FIXED    
Severity: normal CC: brenden, dmr
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://sourceforge.net/tracker/?func=detail&aid=3511972&group_id=143975&atid=757310
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Dot graph patch
The patching ebuild
Improved dot graph patch

Description Alessandro Di Marco 2012-03-15 10:45:43 UTC
Created attachment 305471 [details, diff]
Dot graph patch

Adds -d switch to conky's graph keyword; rather than the usual solid trace, the resulting graph appears as a dot trace when -d is specified.
Comment 1 Alessandro Di Marco 2012-03-15 10:47:05 UTC
Created attachment 305473 [details]
The patching ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2012-03-15 13:51:47 UTC
Comment on attachment 305473 [details]
The patching ebuild

--- conky-1.8.1-r6.ebuild       2012-03-11 19:14:40.000000000 +0100
+++ -   2012-03-15 14:51:35.118390127 +0100
@@ -61,7 +61,8 @@
                "${FILESDIR}/${P}-maxinterfaces.patch" \
                "${FILESDIR}/${P}-utf8-scroll.patch" \
                "${FILESDIR}/${P}-battery-time.patch" \
-               "${FILESDIR}/${P}-lua-5.2.patch"
+               "${FILESDIR}/${P}-lua-5.2.patch" \
+               "${FILESDIR}/${P}-graph.patch"
        eautoreconf
 }
Comment 3 Alessandro Di Marco 2012-03-15 17:25:55 UTC
Created attachment 305541 [details, diff]
Improved dot graph patch

Traces look better with this one.
Comment 4 Daniel Pielmeier gentoo-dev 2012-03-16 12:48:07 UTC
Why don't you report this patch upstream? Wouldn't this make more sense?
Comment 5 Alessandro Di Marco 2012-03-16 22:53:00 UTC
(In reply to comment #4)
> Why don't you report this patch upstream? Wouldn't this make more sense?

No way. The upstream only wants patches for the next major release of Conky which is rather different by this one. So I preferred to make a patch rather than a patch and an (unstable) ebuild.
Comment 6 Daniel Pielmeier gentoo-dev 2012-03-19 07:43:36 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Why don't you report this patch upstream? Wouldn't this make more sense?
> 
> No way. The upstream only wants patches for the next major release of Conky
> which is rather different by this one. So I preferred to make a patch rather
> than a patch and an (unstable) ebuild.

Who says that? There is 1.8.2 somewhere at the horizon, so the patch could go there! Btw, brenden what about a release including this last patch :)
Comment 7 Alessandro Di Marco 2012-03-20 23:33:26 UTC
LOL. Btw I sent an updated patch for 1.8.2 to conky-development mailing list..
Comment 8 Daniel Pielmeier gentoo-dev 2012-03-21 07:54:20 UTC
(In reply to comment #7)
> LOL. Btw I sent an updated patch for 1.8.2 to conky-development mailing
> list..

The source forge tracker would be a better place for this.
Comment 9 Daniel Pielmeier gentoo-dev 2012-05-05 15:22:41 UTC
+*conky-1.9.0 (05 May 2012)
+
+  05 May 2012; Daniel Pielmeier <billie@gentoo.org> +conky-1.9.0.ebuild:
+  Version bump.

Should be fixed in conky-1.9.0.

@Brenden: Thanks for including the patch and the new version.