Bug 407319

Summary:	media-gfx/argyllcms and gnome-color-manager do not play along
Product:	Gentoo Linux	Reporter:	Morse <radist.morse>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugzilla.gnome.org/show_bug.cgi?id=672028
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch for gnome-color-manager upstreamable patch

Description Morse 2012-03-07 19:00:25 UTC

when I try to calibrate my screen using GNOME3 standart tools (gnome-control-centre color, gnome-color-manager, argyllcms), I can't do it, because of filename changing: argyllcms ebuild renames all binaries from the package prefixing it with "argyll-", which makes them impossible to use by gnome.

Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-03-07 19:14:12 UTC

Thanks for reporting. I see that our gnome-color-manager tries to launch "dispcal" instead of "argyll-dispcal". Are there any other argyllcms executables that gnome-color-manager calls incorrectly?

Comment 2 Morse 2012-03-07 19:37:14 UTC

That I don't know, but I suppose that all of them. As I installed argyllcms from local overlay anyway, I just removed this prefixes from ebuild. I didn't try to launch calibration renaming agryll binaries one at a time.

Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-03-07 23:04:45 UTC

Fixed, thanks for reporting.

>*gnome-color-manager-3.2.2-r1 (07 Mar 2012)
>
>  07 Mar 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -gnome-color-manager-3.2.1.ebuild, +gnome-color-manager-3.2.2-r1.ebuild,
>  +files/gnome-color-manager-3.2.2-argyll-prefix.patch:
>  Use the correct name for Gentoo's argyll-dispcal; add a pkg_postinst message
>  about argyllcms (bug #407319, thanks to Morse). Drop old.

Comment 4 Morse 2012-03-09 16:39:26 UTC

Created attachment 304741 [details, diff]
patch for gnome-color-manager

Comment 5 Morse 2012-03-09 16:40:42 UTC

Not quite fixed yet. g-c-m calls for dispcal in three different places.

Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-03-11 04:28:55 UTC

Created attachment 304893 [details, diff]
upstreamable patch

Please test this patch; I believe it should also work on all distros, and would therefore be acceptable for inclusion in gnome-color-manager upstream.

Comment 7 Morse 2012-03-12 12:39:15 UTC

You need a patch for your patch :)

line 26:
-	if (!command == NULL)
+	if (command == NULL)

Othen that that - yes, it's working. good to go to upstream.

Comment 8 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-03-14 03:47:43 UTC

(In reply to comment #7)

Thanks!

Updated the patch in portage and submitted upstream at https://bugzilla.gnome.org/show_bug.cgi?id=672028

>*gnome-color-manager-3.2.2-r2 (14 Mar 2012)
>
>  14 Mar 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -gnome-color-manager-3.2.2-r1.ebuild, +gnome-color-manager-3.2.2-r2.ebuild,
>  files/gnome-color-manager-3.2.2-argyll-prefix.patch:
>  Fix the argyll-dispcal patch so it works properly (bug #407319).