| Summary: | net-mail/queue-repair - /usr/bin/queue-repair.py: AttributeError: 'dict_keys' object has no attribute 'sort' | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Oliver Welter <gentoo> |
| Component: | Current packages | Assignee: | Net-Mail Packages <net-mail+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | grknight, montar, patrick, redwolfe |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Fixes issues mentioned by python upgrade guide
queue-repair-0.9.0-r1.patch |
||
Created attachment 303339 [details, diff]
Fixes issues mentioned by python upgrade guide
Comment on attachment 303339 [details, diff]
Fixes issues mentioned by python upgrade guide
That's a nice patch for upstream - a nicer (ebuild) patch would simply set the required python version as a runtime dependency, and also set the proper shebang in the script.
Created attachment 370248 [details, diff]
queue-repair-0.9.0-r1.patch
Patch to use python-single-r1.eclass
I would say... go ahead and fix this finally :/ Thanks *** Bug 415929 has been marked as a duplicate of this bug. *** *** Bug 435334 has been marked as a duplicate of this bug. *** *** Bug 514096 has been marked as a duplicate of this bug. *** Committed queue-repair-0.9.0-r1 |
The net-mail/queue-repair script is not running on python3. I fixed the obvious stuff (octal notation, error excepts) so the script compiles, but now I get this error when executing it: Traceback (most recent call last): File "/usr/bin/queue-repair.py", line 778, in <module> main() File "/usr/bin/queue-repair.py", line 774, in main check_queue(qmaildir, test, force_split, force_bigtodo, create, mathishard) File "/usr/bin/queue-repair.py", line 686, in check_queue check_dirs(dirs, split, bigtodo) File "/usr/bin/queue-repair.py", line 334, in check_dirs _dirs.sort() AttributeError: 'dict_keys' object has no attribute 'sort' I dont have any idea of python, so perhaps anybody can fix this... Reproducible: Always Steps to Reproduce: 1. Switch to python3+ 2. Fix Octal Notations and except/raise statements (see patch) 3. Execute /usr/bin/queue-repair.py Actual Results: Traceback (most recent call last): File "/usr/bin/queue-repair.py", line 778, in <module> main() File "/usr/bin/queue-repair.py", line 774, in main check_queue(qmaildir, test, force_split, force_bigtodo, create, mathishard) File "/usr/bin/queue-repair.py", line 686, in check_queue check_dirs(dirs, split, bigtodo) File "/usr/bin/queue-repair.py", line 334, in check_dirs _dirs.sort() AttributeError: 'dict_keys' object has no attribute 'sort' Expected Results: work =)