Bug 405747

Summary:	net-firewall/shorewall-4.5.0.1 misses dependency on dev-perl/Digest-SHA1
Product:	Gentoo Linux	Reporter:	Michel Wendrich <m.wendrich>
Component:	New packages	Assignee:	Vieri <rentorbuy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	heltem+gentoo, netmon, ralfglauberman
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Michel Wendrich 2012-02-25 13:00:40 UTC

The new 4.5.0.1 ebuilds for shorewall are missing a dependency on dev-perl/Digest-SHA1.
The shorewall website page about upgrade issues (http://www.shorewall.net/upgrade_issues.htm#idp3461800) states that it's become mandatory for versions >=4.5.0

Reproducible: Always

Steps to Reproduce:
1. Unmerge net-firewall/shorewall-4.4.27 (to avoid package file collisions with net-firewall/shorewall-core-4.5.0.1)
2. Emerge net-firewall/shorewall-4.5.0.1
3. etc-update
4. /etc/init.d/shorewall restart
Actual Results:  
 * Starting firewall ...Can't locate Digest/SHA1.pm in @INC (@INC contains: /usr/share/shorewall /etc/perl /usr/lib64/perl5/site_perl/5.12.4/x86_64-linux /usr/lib64/perl5/site_perl/5.12.4 /usr/lib64/perl5/vendor_perl/5.12.4/x86_64-linux /usr/lib64/perl5/vendor_perl/5.12.4 /usr/lib64/perl5/site_perl /usr/lib64/perl5/vendor_perl /usr/lib64/perl5/5.12.4/x86_64-linux /usr/lib64/perl5/5.12.4 /usr/local/lib/site_perl .) at /usr/share/shorewall/Shorewall/Chains.pm line 31.
BEGIN failed--compilation aborted at /usr/share/shorewall/Shorewall/Chains.pm line 31.
Compilation failed in require at /usr/share/shorewall/Shorewall/Compiler.pm line 27.
BEGIN failed--compilation aborted at /usr/share/shorewall/Shorewall/Compiler.pm line 27.
Compilation failed in require at /usr/share/shorewall/compiler.pl line 45.
BEGIN failed--compilation aborted at /usr/share/shorewall/compiler.pl line 45.                                                                         [ !! ]
 * ERROR: shorewall failed to start


Expected Results:  
Starting up shorewall without any errors.

Comment 1 Constanze Hausner (RETIRED) gentoo-dev

2012-02-27 17:07:27 UTC

Sorry, I missed that. Fixed it by adding the dependency to shorewall-core.

Comment 2 Heltem 2012-03-02 14:36:34 UTC

It seems virtual/perl-Digest-SHA is not a virtual for dev-perl/Digest-SHA1 but only for perl-core/Digest-SHA which are different.
So missing dependency seems not fixed yet.

Comment 3 Constanze Hausner (RETIRED) gentoo-dev

2012-03-02 17:18:30 UTC

Okay, changed the dep to dev-perl/Digest-SHA1. Sorry for the inconvenience, hope I got it right this time ;).

Comment 4 Vieri 2012-03-03 15:32:20 UTC

I'm not too sure about portage tree policies but I think you can delete

shorewall-core-4.5.0.1
shorewall-core-4.5.0.1-r1

and rename shorewall-core-4.5.0.1-r2 to shorewall-core-4.5.0.1.

Users who already have the dependency installed won't notice the difference. Those who don't will only need to emerge sync.

Just an unimportant suggestion... ;-)

Thanks for the great work.