Bug 405711

Summary:	virtual/freedesktop-icon-theme: Optional dependencies not clear
Product:	Gentoo Linux	Reporter:	Martin Gebert <Murphy.Gebert>
Component:	New packages	Assignee:	Gentoo Linux bug wranglers <bug-wranglers>
Status:	RESOLVED TEST-REQUEST
Severity:	minor
Priority:	Normal
Version:	unspecified
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	New ebuild revision introducing useflags for the available icon themes. Patch of the above ebuild against the current portage revision.

Description Martin Gebert 2012-02-25 08:45:37 UTC

In order to prevent confusion as in bug 403765, please provide use flags or some other obvious way to find out the dependency options of virtual/freedesktop-icon-theme.

Reproducible: Always

Actual Results:  
freedesktop-icon-theme silently depends on an installed icon theme. If none of the provided RDEPENDs is installed it automatically resolves to Gnome icons, which is wrong (and perhaps the most heavyweight of the available choices) on systems not running Gnome.

Expected Results:  
There should be an obvious way (for the average portage user) to change the default dependency. Alternatively the default should be as lightweight as possible.

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2012-02-25 09:34:12 UTC

gnome-icon-theme is the most up to date with the freedesktop.org icon theme specification the virtual is reflecting upon

so it should be primary alternative, for gnome and non-gnome users

there is really nothing to change here

Comment 2 Martin Gebert 2012-02-25 19:45:26 UTC

I'm sorry you didn't care to consider my primary suggestion, making the icon theme configurable. Well, in the following attachments you'll find a new ebuild (marked -0-r1) and the appropriate patch (for -0) to add that choice. This solution uses two global use flags, gnome and kde, and three local ones: faenza, lxde, tango. Default is gnome, so this should be compatible to any current system out there, and your preference.
I'd like to have the ebuild reviewed to make sure there's no ebuild catch I didn't know of. If there isn't I think this should be introduced into the portage tree, as it fixes possible future hassles (and perhaps issues) without (I hope) introducing new ones.

Comment 3 Martin Gebert 2012-02-25 19:46:24 UTC

Created attachment 303211 [details]
New ebuild revision introducing useflags for the available icon themes.

Comment 4 Martin Gebert 2012-02-25 19:47:29 UTC

Created attachment 303215 [details, diff]
Patch of the above ebuild against the current portage revision.