Summary: | app-misc/dnetc uses deprecated variables in init.d script | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Robin Johnson <robbat2> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ahipp0, mjo |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 381895 | ||
Attachments: |
dnetc init.d script update
dnetc init.d script update v2 dnetc.init dnetc.init |
Description
Agostino Sarubbo
2012-02-24 08:56:07 UTC
Created attachment 375936 [details, diff]
dnetc init.d script update
The first hunk of the patch replaces opts with extra_commands and extra_started_commands.
It also adds short descriptions for the commands and for the script itself.
The second hunk replaces deprecated --chuid option with an equivalent --user option.
Other changes are not related to this bug and mostly fixes start-stop-daemon unable to stop and/or signal dnetc processes:
* Stopping distributed.net client ...
* start-stop-daemon: no matching processes found [ ok ]
Instead, rely on dnetc builtin process management.
Created attachment 375948 [details, diff] dnetc init.d script update v2 This is a slightly updated attachment 375936 [details, diff]. It contains one more change in the second hunk (--name option) to prevent openrc from reporting dnetc as crashed. Created attachment 488706 [details]
dnetc.init
I took my own shot at this. Since BUFFER_BASE_DIR is defined in the conf.d file that we ship, there's no need to worry about it being empty. And by switching to -noquiet and letting OpenRC manage the PID file, I was able to get rid of the start/stop functions entirely.
Created attachment 488830 [details]
dnetc.init
Oops, command_args_foreground is actually a no-op. This moves -noquiet into command_args.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=446f997c23defe312ab8e5b386dcef06e01a29f1 commit 446f997c23defe312ab8e5b386dcef06e01a29f1 Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2019-09-14 23:28:34 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2019-09-14 23:29:59 +0000 app-misc/dnetc: Remove last-rited package Closes: https://bugs.gentoo.org/405521 Closes: https://bugs.gentoo.org/691946 Bug: https://bugs.gentoo.org/630808 Closes: https://bugs.gentoo.org/691252 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> app-misc/dnetc/Manifest | 6 -- app-misc/dnetc/dnetc-2.9108.517.ebuild | 93 ------------------------------ app-misc/dnetc/dnetc-2.9112.521.ebuild | 100 --------------------------------- app-misc/dnetc/files/dnetc.confd | 18 ------ app-misc/dnetc/files/dnetc.initd | 88 ----------------------------- app-misc/dnetc/metadata.xml | 11 ---- 6 files changed, 316 deletions(-) |