| Summary: | [kde overlay] app-text/kbibtex-9999 modify for build system to pick up svn revision | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Erik Quaeghebeur <gentoo> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | CC: | creffett |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://gna.org/bugs/?19358#comment4 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
I guess the comparison operator should be
${PV} = *9999*
to cover cases like version 0.4.9999 for the stable branch in SVN (see bug 401585 for details)
testuser@localhost ~/kde/kde/app-text/kbibtex $ ebuild kbibtex-9999.ebuild clean install -- Installing: /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/image/usr/share/man/man1/kbibtex.1 -- Installing: /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/image/usr/share/mime/packages/bibliography.xml >>> Completed installing kbibtex-9999 into /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/image/ testuser@localhost ~/kde/kde/app-text/kbibtex $ grep version.h /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/temp/build.log Scanning dependencies of target set_version_h_in_builddir [ 1%] Updating /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/work/kbibtex-9999_build/src/version.h... [ 1%] Built target set_version_h_in_builddir [ 1%] Updating /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/work/kbibtex-9999_build/src/version.h... [ 1%] Built target set_version_h_in_builddir DID NOT REPLICATE Adding the src_configure() block from the Description, it does indeed 'work'. testuser@localhost ~/kde/kde/app-text/kbibtex $ ebuild kbibtex-9999.ebuild clean install -- Installing: /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/image/usr/share/man/man1/kbibtex.1 -- Installing: /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/image/usr/share/mime/packages/bibliography.xml >>> Completed installing kbibtex-9999 into /mnt/gen2/TmpDir/portage/app-text/kbibtex-9999/image/ merging into the system is not the focus of this bug. Both forms make an effective build. Actually, if [[ ${PV} == *9999* ]] appears preferred I can't replicate the error either. If you still have this issue, please attach build.log. Thx Chris & Ian. I cant reproduce it by myself. I think this is issue is solved by upstream. So no ebuild changes are needed. |
When building app-text/kbibtex-9999 from the kde overlay, the build stops with an error about missing 'version.h'. This seems due to gentoo not including .svn directories. Upstream modified the build system to allow a different way to set the revision and provided a modification to the ebuild. The following should be appended (with corrected indentation, of course): src_configure() { if [[ ${PV} = 9999 ]] ; then SVN_PATH="${ESVN_STORE_DIR}/${ESVN_PROJECT}/${ESVN_REPO_URI##*/}" export SVN_REV=`svnversion ${SVN_PATH}` fi kde4-base_src_configure } I tested this, and it works for me. Reproducible: Always