Bug 405113

Summary:	kde-misc/tellico shouldn't depend on media-libs/musicbrainz at all (was: missing SLOT in the depend)
Product:	Gentoo Linux	Reporter:	Samuli Suominen (RETIRED) <ssuominen>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Samuli Suominen (RETIRED) gentoo-dev

2012-02-21 07:30:51 UTC

You need to pick a SLOT... This is the only ebuild in Portage with improper depend for musicbrainz

kde-misc/tellico/tellico-2.3.4.ebuild:	musicbrainz? ( >=media-libs/musicbrainz-2.1.5 )
kde-misc/tellico/tellico-2.3.5.ebuild:	musicbrainz? ( >=media-libs/musicbrainz-2.1.5 )

$ grep SLOT *.ebuild
musicbrainz-2.1.5.ebuild:SLOT="1"
musicbrainz-3.0.2.ebuild:SLOT="3"
musicbrainz-3.0.3.ebuild:SLOT="3"
musicbrainz-4.0.0.ebuild:SLOT="4"

Comment 1 Johannes Huber (RETIRED) gentoo-dev

2012-02-21 16:03:09 UTC

Fixed. Thanks for reporting.

Comment 2 Tomasz Golinski 2012-03-01 18:18:23 UTC

Does tellico really needs musicbrainz:1? I couldn't find any information about it. It works fine for me with media-libs/musicbrainz-3.0.2:3 which is the most current stable version. 

Including dependency on musicbrainz:1 means adding older version of library for most users.

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2012-03-02 00:51:03 UTC

indeed, quick grepping through sourcetree and couldn't find any reference to the actual libmusicbrainz library being used

tellico just seems to have internal support. propably a feature that should always be enabled if it doesn't have external dependencies.

reopening for maintainers to re-evaluate

Comment 4 Michael Palimaka (kensington) gentoo-dev

2012-03-03 08:34:53 UTC

(In reply to comment #3)
> indeed, quick grepping through sourcetree and couldn't find any reference to
> the actual libmusicbrainz library being used
> 
> tellico just seems to have internal support. propably a feature that should
> always be enabled if it doesn't have external dependencies.
> 
> reopening for maintainers to re-evaluate

I agree: in fact, autodep reports that it is not used at all during compilation.

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2012-03-15 18:38:44 UTC

thanks guys

+  15 Mar 2012; Samuli Suominen <ssuominen@gentoo.org> tellico-2.3.4.ebuild,
+  tellico-2.3.5.ebuild:
+  Remove no-op USE="musicbrainz" and depend wrt #405113 by Tomasz Golinski and
+  Michael (kensington)