Bug 404999 – www-client/firefox-10.0.1 USE=bindist uses mozilla branding with

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Nuno Silva 2012-02-20 10:28:59 UTC]

When upgrading firefox to 10.0.1, it shows "Mozilla Firefox" in the title bar (and everywhere else), and uses the fox globe icon for the window icon, about screen and other dialogs, although I've been using USE=bindist for ages.

I upgraded from 9.0, which built without mozilla branding, as expected.

Diffing the ebuilds, there's no difference that explains this change — after all, I can't even find any code that will change the icons in the ebuild itself, so I *guess* it's an issue with the configure script or some other piece of code from upstream.

Apologies for the lack of research — I will see if I get the time to (properly) debug this issue later today.

Reproducible: Always

Steps to Reproduce:
1. echo www-client/firefox bindist >> /etc/portage/package.use
2. emerge =www-client/firefox-10.0.1
3. firefox

Actual Results:  
If you have extensions and you're upgrading, it will even show the "checking for compatibility" screen with the fox logo and reading "Firefox is checking...". After the first start, you should see the window, named "Mozilla Firefox" and with the fox icon.

Expected Results:  
A window with the title "Aurora", and a blue globe as its icon.

This is happening on an amd64 GNU/Linux, hence the platform and OS I set for the bug, but I seriously doubt this is platform/system-specific.

[Comment 1 Jory A. Pratt 2012-02-21 02:30:07 UTC]

Please attach a config.log

[Comment 2 Dustin Polke 2012-02-21 10:29:28 UTC]

Created attachment 302681 [details]
${WORKDIR}/mozilla-release/obj-x86_64-unknown-linux-gnu/js/src/config.log

Same here. There are two config.logs that I've found, so I'll attach them both.

[Comment 3 Dustin Polke 2012-02-21 10:30:21 UTC]

Created attachment 302683 [details]
${WORKDIR}/mozilla-release/obj-x86_64-unknown-linux-gnu/config.log

[Comment 4 Jory A. Pratt 2012-02-22 03:33:05 UTC]

Created attachment 302769 [details, diff]
ensure firefox uses unofficial when bindist enabled

Please give this a spin.

[Comment 5 Dustin Polke 2012-02-23 18:55:36 UTC]

(In reply to comment #4)
> Created attachment 302769 [details, diff] [details, diff]
> ensure firefox uses unofficial when bindist enabled
> 
> Please give this a spin.
With that patch, the window shows "Mozilla Developer Preview". About dialog stats "Nightly 10.0.1"

[Comment 6 Jory A. Pratt 2012-02-23 23:54:28 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > Created attachment 302769 [details, diff] [details, diff] [details, diff]
> > ensure firefox uses unofficial when bindist enabled
> > 
> > Please give this a spin.
> With that patch, the window shows "Mozilla Developer Preview". About dialog
> stats "Nightly 10.0.1"

I am still going over a few things with upstream, it appears the naming is gonna be completely different from here out. Soon as I have more info I will update everyone.

[Comment 7 Jory A. Pratt 2012-02-27 18:13:12 UTC]

(In reply to comment #0)
> Expected Results:  
> A window with the title "Aurora", and a blue globe as its icon.

I am not sure I am following why you believe it should be Aurora. Aurora is the branding for beta releases. Which would leave nightly, official, and unofficial. None of these are good matches, but I am still working with upstream to decide how we will handle this.

[Comment 8 Jory A. Pratt 2012-02-28 01:08:26 UTC]

Created attachment 303555 [details, diff]
FX branding using aurora

I have cleared this with upstream, they are fine with us using aurora for bindist builds. Soon as this is tested will get committed to the tree.

[Comment 9 Jory A. Pratt 2012-02-28 03:57:05 UTC]

Thanks for reporting, I have committed the appropriate fix to the tree. If you should fine a problem please feel free to reopen this bug if related or a new bug if need be.

[Comment 10 Nikos Chantziaras 2012-02-28 07:09:56 UTC]

(In reply to comment #9)
> Thanks for reporting, I have committed the appropriate fix to the tree. If
> you should fine a problem please feel free to reopen this bug if related or
> a new bug if need be.

I use "-bindist" and now Firefox is messed up :-P  It says "Aurora" instead of "Firefox" and my theme (Oxygen KDE) doesn't work correctly anymore.

[Comment 11 Nikos Chantziaras 2012-02-28 07:44:57 UTC]

I reverted from 10.0.1-r1 back to 10.0.1, but the problem persists! What just happened?

[Comment 12 Dustin Polke 2012-02-28 09:27:51 UTC]

(In reply to comment #10)
> (In reply to comment #9)
> > Thanks for reporting, I have committed the appropriate fix to the tree. If
> > you should fine a problem please feel free to reopen this bug if related or
> > a new bug if need be.
> 
> I use "-bindist" and now Firefox is messed up :-P  It says "Aurora" instead
> of "Firefox" and my theme (Oxygen KDE) doesn't work correctly anymore.

Reopening. Jory, could you please have a look at this?

[Comment 13 Jory A. Pratt 2012-02-28 13:01:37 UTC]

(In reply to comment #12)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > Thanks for reporting, I have committed the appropriate fix to the tree. If
> > > you should fine a problem please feel free to reopen this bug if related or
> > > a new bug if need be.
> > 
> > I use "-bindist" and now Firefox is messed up :-P  It says "Aurora" instead
> > of "Firefox" and my theme (Oxygen KDE) doesn't work correctly anymore.
> 
> Reopening. Jory, could you please have a look at this?

There is nothing to look at, your tree is out of sync, I made an error in the elcass which has already been fixed. http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/mozconfig-3.eclass?revision=1.29&view=markup Sorry for the inconvience.

[Comment 14 Billy DeVincentis 2012-02-29 13:22:46 UTC]

Well, I have a problem here with this
Here is my config for firefox

Final environment Use flags: +alsa, +crashreporter, +dbus, +ipc, +libnotify, +minimal, +startup-notification, +webm, -bindist, -pgo, -system-sqlite, -custom-cflags, -custom-optimization, -debug, -system-sqlite, -wifi, -pgo, -linguas_af, -linguas_ak, -linguas_ar, -linguas_as, -linguas_ast, -linguas_be, -linguas_bg, -linguas_bn_BD, -linguas_bn_IN, -linguas_br, -linguas_bs, -linguas_ca, -linguas_cs, -linguas_csb, -linguas_cy, -linguas_da, -linguas_de, -linguas_el, -linguas_en_GB, -linguas_en_ZA, -linguas_eo, -linguas_es_AR, -linguas_es_CL, -linguas_es_ES, -linguas_es_MX, -linguas_et, -linguas_eu, -linguas_fa, -linguas_fi, -linguas_fr, -linguas_fy_NL, -linguas_ga_IE, -linguas_gd, -linguas_gl, -linguas_gu_IN, -linguas_he, -linguas_hi_IN, -linguas_hr, -linguas_hu, -linguas_hy_AM, -linguas_id, -linguas_is, -linguas_it, -linguas_ja, -linguas_kk, -linguas_kn, -linguas_ko, -linguas_ku, -linguas_lg, -linguas_lt, -linguas_lv, -linguas_mai, -linguas_mk, -linguas_ml, -linguas_mr, -linguas_nb_NO, -linguas_nl, -linguas_nn_NO, -linguas_nso, -linguas_or, -linguas_pa_IN, -linguas_pl, -linguas_pt_BR, -linguas_pt_PT, -linguas_rm, -linguas_ro, -linguas_ru, -linguas_si, -linguas_sk, -linguas_sl, -linguas_son, -linguas_sq, -linguas_sr, -linguas_sv_SE, -linguas_ta, -linguas_ta_LK, -linguas_te, -linguas_th, -linguas_tr, -linguas_uk, -linguas_vi, -linguas_zh_CN, -linguas_zh_TW, -linguas_zu


And I have aurora in my window title and help, about shows that my browser is aurora, not firefox. You might have fixed this for unofficial but for those who want official, it's not working.

[Comment 15 Nikos Chantziaras 2012-02-29 17:14:05 UTC]

Did you sync and rebuild as suggested above?