Bug 403679

Summary:	x11-wm/windowmaker-0.95.1 please include dockhotkeys
Product:	Gentoo Linux	Reporter:	Yuri Karaban <dev>
Component:	Current packages	Assignee:	Gentoo Gnustep project <gnustep>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	jrmalaq
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://lists.windowmaker.org/dev/msg01575.html
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	dockhotkeys patch ported to 0.95.2

Description Yuri Karaban 2012-02-14 19:12:14 UTC

Hi

Ebuild for windowmaker 0.92.0-r11 comes with a set of useful patches (windowmaker-0.92.0-patchset-5.tar.bz2). Unfortunately new ebuild does not include none of these fancy features.

Very handy feature, implemented by WindowMaker-0.91.0-alt-dockhotkeys.patch, is to allow to assign hotkeys for dock lanuchers (works like "Keyboard shortcuts" in WPrefs).

Please consider including this feature in a new ebuild.

Thanks!

Comment 1 Bernard Cafarelli gentoo-dev

2012-02-20 22:17:50 UTC

Sadly, as you probably saw, only a few parts of the patch still apply cleanly, and the rest is not trivial to fix.

Most of the extra features we had in our patchset were added upstream (with proper preferences settings), so it is probably worth asking on the developement mailing list:
http://windowmaker.org/lists.php

Of course, an updated patch would be even better :)

Comment 2 Bernard Cafarelli gentoo-dev

2012-02-26 22:43:31 UTC

I found the original request to merge this patch. The other ALT patches did get in the new version, so this may still get in if the problem is fixed

Comment 3 Yuri Karaban 2012-03-29 13:04:40 UTC

Created attachment 307067 [details, diff]
dockhotkeys patch ported to 0.95.2

I ported dockhotkey patch to apply to 0.95.2. Please include it.

Comment 4 Bernard Cafarelli gentoo-dev

2012-03-29 15:58:21 UTC

Thanks for the updated patch :) I will check and add it when my dev box is back online

In the meantime, can you send it upstream? The original developer (from ALT) still follows the wmaker-dev list, and getting it in upstream would be nice

Comment 5 Bernard Cafarelli gentoo-dev

2012-03-29 16:06:33 UTC

Forgot the URL:
http://windowmaker.org/wmaker-dev.php

Comment 6 Yuri Karaban 2012-03-29 17:33:48 UTC

Thanks!

I'll read how to submit patches on windowmaker.org and I try to submit it.

Comment 7 Bernard Cafarelli gentoo-dev

2017-11-24 10:34:25 UTC

Cleaning old bugs

As upstream is alive and kicking, I'd really prefer to get this pushed there first