Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 402833

Summary: net-im/leechcraft-azoth should use global USE flags where possible
Product: Gentoo Linux Reporter: Nikoli <nikoli>
Component: New packagesAssignee: Gentoo Leechcraft Maintainers <leechcraft>
Severity: minor    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---

Description Nikoli 2012-02-09 10:08:22 UTC
modnok -> latex
rosenthal -> spell
xoox -> xmpp
Comment 1 Georg Rudoy 2012-10-08 14:47:01 UTC
I don't think this should be fixed, since it's hardly a bug.

While using global and "conventional" stuff is good, consistency is better, IMO. Azoth's (and LeechCraft's, in general) USE flags don't fully map on Gentoo global USE flags, meaning some subplugins will be enabled by their names (like metacontacts or autopaste), while others will be enabled by global USE flags. To my mind, that'd create confusion among users.
Comment 2 Nikoli 2012-10-08 14:50:55 UTC
A lot packages have both global and local USE flags, it is normal.
Comment 3 Georg Rudoy 2012-10-08 14:55:39 UTC
As LC lead dev I'm strongly against such name style mixing, but distro devs and maintainers have the final word anyway, so if there is a strong reason to mix the names — OK then.

In other words, I understand that sticking to global USE flags helps configure the system, keeping all configure options in one /etc/make.conf, but since in Azoth case not all flags are mapped to globals, some manual configuration would still be required — we don't gain anything but loose the conventional naming.
Comment 4 Dmitry Potapov 2012-11-07 17:01:33 UTC
I've wasted 15 minutes just because leechcraft-azoth ignored my xmpp and jabber USE-flags set in make.conf. I think that non-standard flags must be forbidden as they ruin whole portage philosophy which allows user to forget about any USE-flags adjusting after initial system configuration.
Comment 5 Georg Rudoy 2012-11-07 17:05:33 UTC
I'd be happy to hear a sane standard naming for all currently existing use flags in Azoth (+ one currently not added one, for "shx" or shell command executor).
Comment 6 Sergey Popov gentoo-dev 2012-11-07 19:38:11 UTC
(In reply to comment #5)
> I'd be happy to hear a sane standard naming for all currently existing use
> flags in Azoth (+ one currently not added one, for "shx" or shell command
> executor).

Request is not about replacement of all leechcraft-azoth USE-flags, just of those, which can be replaced by existing widely-used global flags. I agree with Nikoli and Dmitry, will look on this problem...
Comment 7 Sergey Popov gentoo-dev 2012-11-27 13:57:43 UTC
+  27 Nov 2012; Sergey Popov <> leechcraft-azoth-9999.ebuild,
+  metadata.xml:
+  Use global USE-flags, where it is possible, fix description for old flags,
+  wrt bug #402833

I fix this issue for live ebuild only(for backward compatibility)
Comment 8 Nikoli 2012-11-28 08:36:04 UTC
astrality -> telepathy
otroid -> otr
xtazy -> dbus
zheet -> msn
Comment 9 Georg Rudoy 2012-11-28 08:39:26 UTC
(In reply to comment #8)
> xtazy -> dbus
This one is bad idea. xtazy is not a general dbus plugin, and neither it is dbus-enabling plugin itself, so calling it "dbus" is confusing and misleading.

Moreover, we plan moving the Xtazy's subplugin core to first-level plugins, since it's also required in other plugins, and after that xtazy won't be related to dbus at all by itself.
Comment 10 Dmitry Potapov 2012-11-28 16:38:33 UTC
acetamide -> irc

It is not a global flag, but it is used by many widely used IM clients such as: qutim, weechat, ayttm, centerim and other applications line warsow, telepathy-connection-managers etc.
Comment 11 Sergey Popov gentoo-dev 2012-12-08 08:36:23 UTC

zheet -> msn

Cause other change are not correct(such as change xtazy -> dbus) or proposed USE flags for changing are not global.