| Summary: | kde-workspace 4.8.0 packages fail to configure with USE=-opengl | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Nathan Caldwell <saintdev> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hanno, mpogoda |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 402383, 409403 | ||
| Attachments: |
kde-base/kinfocenter-4.8.0.log
kde-workspace-4.8.0.patch |
||
|
Description
Nathan Caldwell
2012-02-03 06:59:39 UTC
Created attachment 300843 [details]
kde-base/kinfocenter-4.8.0.log
This seems to apply not just to kinfocenter, but kde-base/*[-opengl]. Created attachment 301019 [details, diff]
kde-workspace-4.8.0.patch
On closer inspection, this appears to affect kde-workspace packages only.
Attached is a trivial patch to make it optional again (assuming that it really is still optional).
(In reply to comment #3) > Created attachment 301019 [details, diff] [details, diff] > kde-workspace-4.8.0.patch > > On closer inspection, this appears to affect kde-workspace packages only. > > Attached is a trivial patch to make it optional again (assuming that it really > is still optional). Thanks for looking at that Michael. I've updated the summary. I just had emerge decide on a new package order today and kwin did the same thing, so you're probably right. archtester kinfocenter # USE=-opengl ebuild kinfocenter-4.8.0.ebuild install
>>> Completed installing kinfocenter-4.8.0 into /mnt/gen2/tmpdir/portage/kde-base/kinfocenter-4.8.0/image/
--------------------------------------------------------
archtester kinfocenter # nano kinfocenter-4.8.0.ebuild
---------------------------------------------------
src_prepare() {
epatch "${FILESDIR}"/opengl.patch
kde4-meta_src_prepare
}
-----------------------------------------------------
so the patch is effective, reversing a TRUE to a FALSE
I suspect this has a way to go before all packages bundled in kde-workspace pull free if this flaw.
I think we should do it in eclass instead. that would be a yes(In reply to comment #6) > I think we should do it in eclass instead. That would be a yes *** Bug 403211 has been marked as a duplicate of this bug. *** It turns out that OpenGL/OpenGL ES is now mandatory for kwin.
We could do something like this in the eclass:
if [[ "${KMNAME}" == "kde-workspace" ]]; then
if [[ "${PN}" != "kwin" ]]; then
sed -i -e "/^ macro_log_feature(OPENGL_OR_ES_FOUND/s/TRUE/FALSE/" \
"${S}"/CMakeLists.txt || die "kde-workspace sed failed"
fi
fi
(In reply to comment #9) > It turns out that OpenGL/OpenGL ES is now mandatory for kwin. Even if compositing is disabled (or are you saying it can't be disabled)? (In reply to comment #10) > Even if compositing is disabled (or are you saying it can't be disabled)? I am not particularly familiar with KDE internals, but I cannot see any obvious way to disable compositing. *** Bug 405889 has been marked as a duplicate of this bug. *** At least for kwin, it's not possible to build without opengl anymore. I talked to upstream some time ago and basically got a "not supported, makes no sense". So, I'll add a dependency on kdelibs[opengl] in the kwin ebuild. For the other workspace packages, no idea... (In reply to comment #13) > At least for kwin, it's not possible to build without opengl anymore. I > talked to upstream some time ago and basically got a "not supported, makes > no sense". So, I'll add a dependency on kdelibs[opengl] in the kwin ebuild. > > For the other workspace packages, no idea... If it's required and upstream says it makes no sense, why not just remove the USE flag? (In reply to comment #14) > (In reply to comment #13) > > At least for kwin, it's not possible to build without opengl anymore. I > > talked to upstream some time ago and basically got a "not supported, makes > > no sense". So, I'll add a dependency on kdelibs[opengl] in the kwin ebuild. > > > > For the other workspace packages, no idea... > > If it's required and upstream says it makes no sense, why not just remove > the USE flag? For kwin, you can also set USE=gles instead now, but that still requires afaik kdelibs[opengl]. That's why there is still a useflag... Alternative would be to interpret USE=-gles as opengl automatically... (In reply to comment #9) > It turns out that OpenGL/OpenGL ES is now mandatory for kwin. > We could do something like this in the eclass: > if [[ "${KMNAME}" == "kde-workspace" ]]; then > if [[ "${PN}" != "kwin" ]]; then > sed -i -e "/^ > macro_log_feature(OPENGL_OR_ES_FOUND/s/TRUE/FALSE/" \ > "${S}"/CMakeLists.txt || die "kde-workspace > sed failed" > fi > fi Yeah... I put a similar clause in the eclass in both main tree and overlay. It should not hurt in any case since it only prevents failure if opengl is not found. Let's test and see if anything is still broken. |
