Summary: | media-libs/xine-lib-1.2.0-r1 compile failure in osd.c with sys-libs/zlib-1.2.6 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ulrich Müller <ulm> |
Component: | [OLD] Library | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | base-system, m.debruijne, mikko89 |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.xine-project.org/show_bug.cgi?id=454 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info
build.log xine-lib-1.2.0-gzFile.patch |
Description
Ulrich Müller
2012-01-30 08:25:08 UTC
Created attachment 300347 [details]
emerge --info
Created attachment 300349 [details]
build.log
Same thing happens here. i think this is a bug in xine-lib. the zlib API uses gzFile, not a gzFile*. so the xine-lib code probably should convert all instances away from a pointer. A similar error has happened with ImageMagick-6.7.4.10 (https://bugs.gentoo.org/show_bug.cgi?id=401499) resulting in a version bump to imagemagick-6.7.5.0. Created attachment 300433 [details, diff] xine-lib-1.2.0-gzFile.patch (In reply to comment #4) > i think this is a bug in xine-lib. the zlib API uses gzFile, not a gzFile*. > so the xine-lib code probably should convert all instances away from a > pointer. Right, gzFile itself is already defined as a pointer in zlib.h: typedef struct gzFile_s *gzFile; Attached patch makes xine-lib compile with both zlib-1.2.5.1-r2 and zlib-1.2.6. Comment on attachment 300433 [details, diff]
xine-lib-1.2.0-gzFile.patch
looks sane to me
Thanks ulm (and vapier). Fixed in 1.2.0-r2 and reported to upstream here: https://bugs.xine-project.org/show_bug.cgi?id=454 |