| Summary: | media-libs/libmikmod-3.2.0_beta2-r2 compile fails at libtool command when /bin/sh is dash | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Enne Eziarc <gentoo+bugs> |
| Component: | [OLD] Library | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | slyfox |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
/var/log/paludis/1327848069-install-media-libs_libmikmod-3.2.0_beta2-r2:0::gentoo.out
libmikmod-and-dash.patch |
||
Interesting. I can easily reproduce it.
Out of curiosity: how many packages fail for you that way? I guess it
can be "fixed" by calling libtool directly in not via 'sh'.
LIBTOOL='$(SHELL) $(top_builddir)/libtool'
(though libtool has #bash shebang and we have the same thing in /usr/bin/libtool)
Created attachment 301181 [details, diff]
libmikmod-and-dash.patch
Now I see. A fun thing:
Upstream forgot to provide empty libmikmod/Makefile.am so automake didn't
regen Makefile.in files (and old one knows nothing about SHELL variable).
Creating empty file helped.
@sound: what do you think of attached hack? Worth committing w/o revbump?
> @sound: what do you think of attached hack? Worth committing w/o revbump? Was too impatient and committed: > 08 Feb 2012; Sergei Trofimovich <slyfox@gentoo.org> > libmikmod-3.2.0_beta2-r4.ebuild: > Fix build failure when default shell is dash (bug #401329 by Anthony Parsons). I'll try to run 'sh -> dash' on my box for a while to see what will break. Thanks for report, Anthony! (In reply to comment #3) > > @sound: what do you think of attached hack? Worth committing w/o revbump? > > Was too impatient and committed: > > > 08 Feb 2012; Sergei Trofimovich <slyfox@gentoo.org> > > libmikmod-3.2.0_beta2-r4.ebuild: > > Fix build failure when default shell is dash (bug #401329 by Anthony Parsons). > > I'll try to run 'sh -> dash' on my box for a while to see what will break. > > Thanks for report, Anthony! Notice that the -autotools.patch in files/ directory is patching the libmikmod/Makefile.in which this commit now overwrites If that is an issue or not, I have not checked (In reply to comment #1) > Interesting. I can easily reproduce it. > > Out of curiosity: how many packages fail for you that way? (sorry for slow reply, my email's been wedged for a few days) Just this one. I'd been doing some spring cleaning and ended up doing an -e world, I had about 950 packages in all. |
Created attachment 300267 [details] /var/log/paludis/1327848069-install-media-libs_libmikmod-3.2.0_beta2-r2:0::gentoo.out As it says on the tin. Every other ebuild installed on my system seems to get it right. Compile output attached.