Bug 401223

Summary:	gnome-extra/cinnamon-1.2-r1 - mv: cannot move `files/usr/lib' to a subdirectory of itself, `files/usr/lib/lib'
Product:	Gentoo Linux	Reporter:	Adrian Bassett <Adrian.Bassett>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	teidakankan
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	mv directory only when $(get_libdir) is not "lib"

Description Adrian Bassett 2012-01-28 19:40:40 UTC

gnome-extra/cinnamon-1.2.1-r1 fails in src_prepare () on x86 whilst succeeding on AMD64.

The problem line in the ebuild is:

mv files/usr/lib files/usr/$(get_libdir) || die "mv failed"

and the error diagnostic is:

* Applying cinnamon-1.1.3-automagic-gnome-bluetooth.patch ...                                                              [ ok ]
 * Applying cinnamon-1.2-optional-networkmanager.patch ...                                                                  [ ok ]
 * Applying cinnamon-1.1.3-extensionjs_path.patch ...                                                                       [ ok ]
 * Applying cinnamon-1.1.3-xdg-open.patch ...                                                                               [ ok ]
mv: cannot move `files/usr/lib' to a subdirectory of itself, `files/usr/lib/lib'

The problem only arises when $(get_libdir) returns a value such that the mv target is the same as the mv source:  on x86 the returned value is 'lib' whereas on AMD64 it is 'lib64'.

A simple debug statement 'echo files/usr/lib is files/usr/$(get_libdir)' added to the ebuild before the mv statement gives:

x86: files/usr/lib is files/usr/lib
AMD64: files/usr/lib is files/usr/lib64


Reproducible: Always

Comment 1 Lucian Muresan 2012-01-30 10:35:19 UTC

Created attachment 300353 [details, diff]
mv directory only when $(get_libdir) is not "lib"

Is such a fix dirty?

Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-01-30 22:33:34 UTC

(In reply to comment #1)
> Created attachment 300353 [details, diff] [details, diff]
> mv directory only when $(get_libdir) is not "lib"

Fixed, thanks. Sorry that x86 doesn't get much testing these days.

>  30 Jan 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  cinnamon-1.2-r1.ebuild:
>  Fix building on x86 (bug #401223, thanks to Adrian Bassett and Lucian
>  Muresan).