Summary: | games-action/minetest games-action/minetest_game: new ebuilds | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | neko259 <neko259> |
Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | binki, nicklaskarlsson81, sunrise |
Priority: | Normal | Keywords: | EBUILD, InOverlay, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://c55.me/minetest/ | ||
Whiteboard: | [sunrise-overlay], [hasufell-overlay] | ||
Package list: | Runtime testing required: | --- | |
Attachments: |
minetest-0.4.20120320.ebuild
minetest-0.4_pre20120320.ebuild minetest-0.4_pre20120320-cmake.patch minetest-0.4_pre20120320-sharepath.patch minetest_game-0.4_pre20120408.ebuild minetest-0.4_pre20120408.ebuild minetest-0.4_pre20120408-cmake.patch minetest-0.4_pre20120408-sharepath.patch minetest-0.4_pre20120408-jthread.patch minetest-0.4_pre20120408-lua.patch ebuild for minetest-0.4.3 init-script data for minetest engine live ebuild for minetest |
Description
neko259
2012-01-23 17:58:52 UTC
Created attachment 306625 [details]
minetest-0.4.20120320.ebuild
Ebuild for the latest version of minetest.
Added ebuilds to nektoo overlay. Created attachment 307581 [details]
minetest-0.4_pre20120320.ebuild
Created attachment 307583 [details, diff]
minetest-0.4_pre20120320-cmake.patch
Created attachment 307585 [details, diff]
minetest-0.4_pre20120320-sharepath.patch
added to sunrise-overlay available after review: http://git.overlays.gentoo.org/gitweb/?p=proj/sunrise-reviewed.git;a=tree;f=games-action/minetest;hb=HEAD Created attachment 309883 [details]
minetest_game-0.4_pre20120408.ebuild
Created attachment 309885 [details]
minetest-0.4_pre20120408.ebuild
Created attachment 309887 [details, diff]
minetest-0.4_pre20120408-cmake.patch
Created attachment 309889 [details, diff]
minetest-0.4_pre20120408-sharepath.patch
Created attachment 309891 [details, diff]
minetest-0.4_pre20120408-jthread.patch
Created attachment 309893 [details, diff]
minetest-0.4_pre20120408-lua.patch
Created attachment 327946 [details]
ebuild for minetest-0.4.3
Created attachment 327948 [details]
init-script
Created attachment 327950 [details]
data for minetest engine
Created attachment 327952 [details]
live ebuild for minetest
(In reply to comment #13) > Created attachment 327946 [details] > ebuild for minetest-0.4.3 let me comment on a few things... license: - license CCPL-Attribution-ShareAlike-3.0 is missing (cause the engine-part also installs a minimal set of textures/data) deps: - irrlicht is only a build-time dependency, not runtime - gettext is only a build-time dependency, not runtime - libpng is missing a slot (use slot :0 here, cause :1.2 does not even provide headers and is only there for backwardscompatibility. If a user only has :1.2 currently installed the build process would fail) - dependency logic inconsistent if the user does not compile the client - a few deps missing, like virtual/jpeg, media-libs/libvorbis or x11-libs/libXxf86vm useflag-logic: - games should not use a "client" useflag, rather a "dedicated" useflag (which is a global one too) - "game" is actually an invalid useflag, cause it does not change the build process and would trigger a rebuild where none is necessary. Put things like that in an "elog" in "pkg_postinst()" phase builtime: - afaik the build system prefers the static jthread library. We should not, that needs a patch. ebuild/eclass logic: - you have some wrong install destinations due to using DCMAKE_INSTALL_PREFIX=${GAMES_PREFIX}, e.g. /usr/games/share/man/man6 /usr/games/share/icons/hicolor /usr/games/share/applications The build system let's you choose all the locations specifically. Avoid setting install-prefix, but rather use DCUSTOM_SHAREDIR and DCUSTOM_BINDIR - user.eclass should be inherited explicitly when you use functions from it directly - snapshot/tarballs are preferred over EGIT_COMMIT things, cause we have a real Manifest file then. You can use vcs-snapshot eclass for that which uses git-generated tarballs from github - src_prepare has to go before src_configure - games.eclass has to go last, always. That's policy. If you do that you have to keep in mind that it inherits base.eclass and that you have to explictly call cmake-utils_src_compile in src_compile() phase - it's safer to make mycmakeargs a local var - non-portage commands like "rm" have to be appended a "|| die" also "-f" is discouraged and only wanted in some cases. We want to be sure that those dirs with bundles libs are removed, so we want an error if they are not - mkdir -p "${D}/var/lib/minetest" and mkdir -p "${D}/etc/init.d" are wrong, don't do it. Create user and group in "pkg_setup()" instead and do the installation in "src_install()". Also use "fowners" instead of "chown". - EROOT should usually only be used for pkg_* phases. It has no place in src_configure here initscript: I didn't tinker much with the server things. Can we run that stuff in a screen/tmux session? That's usually better. sidenote: I have minetest in my overlay https://github.com/hasufell/hasufell-overlay/tree/master/games-action/minetest you can send pull requests or open an issue like adding the initscript, so we don't duplicate work Thank you for detailed explanation. I've sent you pull request. *** Bug 458476 has been marked as a duplicate of this bug. *** in portage |