Bug 39877 – media-sound/xmms-1.2.9 doesn't build with gcc-2.95

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Tristan Henderson 2004-01-30 07:10:24 UTC]

Can't build xmms-1.2.9 on my gentoo-1.2 box. It's the usual ANSI declaring variables laziness :-)
The problem is in xmms-1.2.9-random.patch - I've attached a fixed version.

main.c:3646: parse error before `int'
main.c:3649: `fd' undeclared (first use in this function)
main.c:3649: (Each undeclared identifier is reported only once
main.c:3649: for each function it appears in.)
main.c:3650: `i' undeclared (first use in this function)
main.c:3651: `randnum' undeclared (first use in this function)
main.c:3652: `randtbl2' undeclared (first use in this function)
main.c: At top level:
../libxmms/charset.h:10: warning: `autocharset_enca' declared `static' but never defined> Unpacking gentoo_ice-xmms-0.2.tar.bz2 to /var/tmp/portage/xmms-1.2.9/work
make[4]: *** [main.o] Error 1                                                         make[4]: Leaving directory `/var/tmp/portage/xmms-1.2.9/work/xmms-1.2.9/xmms'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/xmms-1.2.9/work/xmms-1.2.9/xmms'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/var/tmp/portage/xmms-1.2.9/work/xmms-1.2.9/xmms'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/xmms-1.2.9/work/xmms-1.2.9'
make: *** [all] Error 2

!!! ERROR: media-sound/xmms-1.2.9 failed.
!!! Function src_compile, Line 140, Exitcode 2
!!! (no error message)


Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Portage 2.0.50_pre21 (default-1.0, gcc-2.95.3, glibc-2.2.5-r9, 2.4.24)
==============================================================
===
System uname: 2.4.24 i686 Transmeta(tm) Crusoe(tm) Processor TM5800
Gentoo Base System version 1.4.3.12
distcc 2.12.1 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
Autoconf: sys-devel/autoconf-2.59
Automake: sys-devel/automake-1.7.8
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-mcpu=i686 -O3 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3/share/config 
/usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ 
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ 
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-mcpu=i686 -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache digest sandbox strict"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://distro.ibiblio.
org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X X509 aalib alsa apache2 apm avi berkdb bonobo cdr crypt cups curses dga dvd emacs 
encode esd ethereal evo fbcon foomaticdb gdbm gif gnome-libs gpm gtk gtk2 gtkhtml guile imap 
imlib java jpeg lcms ldap libg++ libwww mmx motif mpeg mysql nas ncurses odbc oggvorbis oss 
pam pcmcia pda pdflib perl pic plotutils png pnp python quicktime readline samba sdl skey slang 
smooth snmp spell ssl stroke svga tcltk tcpd tetex tiff truetype trusted usb vim-with-x x86 xml xml2 
xmms xv zlib"

[Comment 1 Tristan Henderson 2004-01-30 07:10:56 UTC]

Created attachment 24639 [details, diff]
fixed random patch for gcc-2.95

[Comment 2 Jeremy Huddleston (RETIRED) 2004-01-30 11:19:28 UTC]

that patch looks like it fixes main.c, but i think playlist.c has the same problem, so I'll update that one too.  This will make it into the next patchset for the -r1 release hopefully this weekend.

[Comment 3 Tristan Henderson 2004-01-30 11:25:19 UTC]

I think playlist.c is OK. Well, at least it compiled for me.
But I'll leave it in your capable hands...

Thanks!

[Comment 4 Jeremy Huddleston (RETIRED) 2004-01-30 11:33:16 UTC]

weird... well in any event, it's not ANSI, so I'll fix it any way in case it breaks another compiler.

Thanks for pointing this out.

[Comment 5 Martin Holzer (RETIRED) 2004-01-31 06:49:54 UTC]

got this one

patching file xmms/main.c
Hunk #2 succeeded at 38 with fuzz 1 (offset -1 lines).
Hunk #3 succeeded at 3503 (offset -37 lines).
Hunk #4 succeeded at 3525 (offset -39 lines).
patching file xmms/playlist.c
Hunk #1 succeeded at 543 (offset -2 lines).
Hunk #2 FAILED at 1897.
Hunk #3 FAILED at 1982.
2 out of 3 hunks FAILED -- saving rejects to file xmms/playlist.c.rej

[Comment 6 Jeremy Huddleston (RETIRED) 2004-01-31 14:55:43 UTC]

Martin, with this patch or the one in the gentoo patch?  

[Comment 7 Martin Holzer (RETIRED) 2004-01-31 15:04:25 UTC]

with this one

[Comment 8 Jeremy Huddleston (RETIRED) 2004-01-31 17:59:17 UTC]

hmm... it applied fine for me (just replaced the one in the patchset with this one)... in any event, the variable declaration change will be in the patchset for 1.2.9-r1 which I hope to have out this weekend (just one more bug to fix before shipping...)

[Comment 9 Jeremy Huddleston (RETIRED) 2004-01-31 20:21:36 UTC]

In 1.2.9-r1