Summary: | app-emacs/haml-mode and app-emacs/scss-mode (new packages) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paul Jewell <paul> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED OBSOLETE | ||
Severity: | enhancement | CC: | gnu-emacs, xemacs |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
haml-mode-9999.ebuild
scss-mode-9999.ebuild 50scss-mode-gentoo.el 50haml-mode-gentoo.el |
Description
Paul Jewell
2012-01-07 11:57:36 UTC
Created attachment 298207 [details]
haml-mode-9999.ebuild
Created attachment 298209 [details]
scss-mode-9999.ebuild
Created attachment 298211 [details]
50scss-mode-gentoo.el
Created attachment 298213 [details]
50haml-mode-gentoo.el
Uploaded the ebuilds, and the elisp configuration files. I cannot find any upstream releases or version tags. So these will be snapshots with unwieldy package version numbers like haml-mode-3.0.15_pre20101019 and scss-mode-0.5.0_pre20110901. Ebuilds look good to me, just some questions and small remarks: (In reply to comment #1) > haml-mode-9999.ebuild > HOMEPAGE="http://github.com/nex3/haml-mode/trunk/" This doesn't exist, "trunk/" should be deleted. (In reply to comment #2) > scss-mode-9999.ebuild > RDEPEND="app-emacs/haml-mode Why is this needed? (In reply to comment #4) > 50haml-mode-gentoo.el > (add-to-list 'auto-mode-alist '("\\.haml$" . haml-mode)) "\\.haml\\'" is slightly preferred over "\\.haml$" here, because you want to match end of string (and not end of line). (In reply to comment #6) > I cannot find any upstream releases or version tags. So these will be snapshots > with unwieldy package version numbers like haml-mode-3.0.15_pre20101019 and > scss-mode-0.5.0_pre20110901. I recognised this, which is why I built direct from the git archive. > Ebuilds look good to me, just some questions and small remarks: I am learning :), so your comments are very welcome - thanks! > (In reply to comment #1) > > haml-mode-9999.ebuild > > > HOMEPAGE="http://github.com/nex3/haml-mode/trunk/" > > This doesn't exist, "trunk/" should be deleted. OK > (In reply to comment #2) > > scss-mode-9999.ebuild > > > RDEPEND="app-emacs/haml-mode > > Why is this needed? scss mode says it needs haml-mode, but to be honest I haven't actually checked the code to see. Should it be RDEPEND or DEPEND? Perhaps I have it in the wrong place. > (In reply to comment #4) > > 50haml-mode-gentoo.el > > > (add-to-list 'auto-mode-alist '("\\.haml$" . haml-mode)) > > "\\.haml\\'" is slightly preferred over "\\.haml$" here, because you want to > match end of string (and not end of line). Thanks - I am learning more about emacs as well at the moment, despite having used it on and off since the late 80's. Should I make the changes you advised above, and upload them again? (In reply to comment #7) > scss mode says it needs haml-mode, but to be honest I haven't actually > checked the code to see. Should it be RDEPEND or DEPEND? Perhaps I have > it in the wrong place. I believe that it's not needed at all: All function names in haml-mode.el start with "haml-", but that string doesn't ever occur in scss-mode.el. > Should I make the changes you advised above, and upload them again? No, since these are small changes, I'll apply them myself when committing the ebuilds. app-emacs/scss-mode is in the gentoo tree, and I have a copy of haml-mode in my "graaff" overlay. In my opinion, this can now be closed. scss-mode is available in the tree, and as pointed out below haml-mode is available in an overlay. Of course both can now be installed from melpa directly into emacs. |