| Summary: | dev-python/httplib2-0.7.[2,4] suffers test failure with build with pypy-1.7 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Ian Delaney (RETIRED) <idella4> |
| Component: | Current packages | Assignee: | Python Gentoo Team <python> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | Keywords: | TESTFAILURE |
| Priority: | Normal | ||
| Version: | 10.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugs.pypy.org/issue1169 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
my emerge --info
the build log ebuild patch the files/httplib2-0.7.4-pypy_test.patch |
||
Created attachment 297667 [details]
the build log
I committed a fix. Please try again. FEATURES="userpriv test usersandbox
archtester build # emerge =dev-python/httplib2-0.7.2::progress -pv
[ebuild N ] dev-python/httplib2-0.7.2 PYTHON_ABIS="2.5 2.6 2.7 2.7-pypy-1.7 3.2 -2.4 -2.5-jython (-2.6-jython) (-3.3)
>>> Emerging (1 of 1) dev-python/httplib2-0.7.2 from progress
>>> Installing (1 of 1) dev-python/httplib2-0.7.2
Created attachment 315083 [details, diff] ebuild patch from https://bugs.pypy.org/issue1169 "Author: afa Date: 2012-06-11.21:23:22 pypy was using ERR_get_error() instead of ERR_peek_last_error() for certificates errors. Fixed in 25d3418150d2" ------------------------------------------------------------------------------ This may make this patch redundant. However; Having taken up Arfrever's tip to use Python's skipIf feature for pypy, it can't be utilised by Pythons2.[56]. Hence a copy of the key testfile. Created attachment 315085 [details, diff]
the files/httplib2-0.7.4-pypy_test.patch
archtester httplib2 # USE_PYTHON="2.5 2.6 2.7-pypy-1.8 2.7-pypy-1.9" ebuild httplib2-0.7.4.ebuild clean test * Testing of dev-python/httplib2-0.7.4 with CPython 2.5... ....................................................................................................................... ---------------------------------------------------------------------- Ran 119 tests in 87.937s OK * Testing of dev-python/httplib2-0.7.4 with CPython 2.6... ....................................................................................................................... ---------------------------------------------------------------------- Ran 119 tests in 89.017s OK * Testing of dev-python/httplib2-0.7.4 with PyPy 1.8 (Python 2.7)... ..............................................................................................s........................ ---------------------------------------------------------------------- Ran 119 tests in 89.376s OK (skipped=1) * Testing of dev-python/httplib2-0.7.4 with PyPy 1.9 (Python 2.7)... ..............................................................................................s........................ ---------------------------------------------------------------------- Ran 119 tests in 90.554s OK (skipped=1) It is better to backport https://bitbucket.org/pypy/pypy/changeset/25d3418150d2 and not include any ugly changes in dev-python/httplib2 ebuilds. (In reply to comment #7) > It is better to backport agree > https://bitbucket.org/pypy/pypy/changeset/25d3418150d2 and not include any > ugly changes in dev-python/httplib2 ebuilds. if it works, then in my eyes it's not ugly, however it's a 'doffa', since the above is the preferred and it's a question of when |
Created attachment 297665 [details] my emerge --info FEATURES test set; std use flags; pypy-c1.7 httplib2test.py Traceback (most recent call last): File "app_main.py", line 51, in run_toplevel IOError: [Errno 2] No such file or directory: 'httplib2test.py' /mnt/gen2/TmpDir/portage/dev-python/httplib2-0.7.2/temp/environment: line 4021: popd: directory stack empty * ERROR: dev-python/httplib2-0.7.2 failed (test phase): * Testing failed with PyPy 1.7 (Python 2.7) in testing() function