Bug 396209

Summary:	=media-sound/pulseaudio-1.1-r1: Modify init script to handle dbus/bluetooth (?)
Product:	Gentoo Linux	Reporter:	Elias Probst <mail>
Component:	New packages	Assignee:	Arun Raghavan (RETIRED) <ford_prefect>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nikoli, sound
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to fix the USE flag requirement build.log of an failed attempt to build pulseaudio with USE="bluetooth -dbus" Patch to fix the D-Bus requirement in the initscript

Description Elias Probst 2011-12-27 14:50:28 UTC

When trying to build media-sound/pulseaudio-1.1 with USE="bluetooth -dbus", it fails, as the bluetooth support of PulseAudio requires D-Bus to work.

Reproducible: Always

Steps to Reproduce:
1. Set USE="bluetooth -dbus"
2. Try to emerge media-sound/pulseaudio-1.1
Actual Results:  
media-sound/pulseaudio-1.1 fails to build (see attached build.log)

Expected Results:  
media-sound/pulseaudio-1.1 should request the needed USE flag 'dbus' as requirement.

A patch to fix will be attached.
I don't know, whether this is also valid for <media-sound/pulseaudio-1.1

Comment 1 Elias Probst 2011-12-27 14:53:05 UTC

Created attachment 297085 [details, diff]
Patch to fix the USE flag requirement

Comment 2 Elias Probst 2011-12-27 14:54:05 UTC

Created attachment 297087 [details]
build.log of an failed attempt to build pulseaudio with USE="bluetooth -dbus"

Comment 3 Elias Probst 2011-12-27 15:40:41 UTC

Created attachment 297093 [details, diff]
Patch to fix the D-Bus requirement in the initscript

I've just noticed that the initscript is also missing the needed dependency on D-Bus.

Please review the attached patch, it works here, but I'm not sure, whether there are more components which could make D-Bus a dependency.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2012-01-22 21:54:06 UTC

Comment on attachment 297085 [details, diff]
Patch to fix the USE flag requirement

I've applied USE_REQUIRED change to pulseaudio-1.1-r1 and 9999, so this is not necessary anymore.

Comment 5 Arun Raghavan (RETIRED) gentoo-dev

2012-02-13 03:32:41 UTC

The dependency should be on bluetooth actually, but I don't want to make it unconditional in the init script, so people are going to have to deal with this manually if required. Since system-wide mode really isn't recommended anyway, this is acceptable.

Thanks for fixing up the REQUIRED_USE, Samuli.