| Summary: | x11-proto/xproto: add x32 support (fix building of pkgs like x11-libs/libXmu) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sergei Trofimovich (RETIRED) <slyfox> |
| Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | marduk, radhermit, xaviermiller |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 393673 | ||
| Attachments: |
patch against latest x11-proto/xproto (quite invasive)
patch against latest x11-libs/libXt (similar to above) patch against latest x11-proto/xproto (less invasive this time) |
||
Created attachment 296447 [details, diff]
patch against latest x11-libs/libXt (similar to above)
Looks like (out-of-sync) libXt's copy is the same.
What is the upstream status of this patch? didn't show it anyone Sent an email. The battle has begun. In short, __LP64__ is a bad guard for non-gcc. http://lists.x.org/archives/xorg-devel/2011-December/027949.html @x11: What do you think of conditionally patching both things:
has x32 $(get_all_abis) && epatch
not exactly nice, but quite safe.
Created attachment 314459 [details, diff] patch against latest x11-proto/xproto (less invasive this time) Updated patch to use recently introduced __ILP32__. Sent upstream in the tail of flamy thread: http://www.mail-archive.com/xorg-devel@lists.x.org/msg27303.html Patching /usr/include/X11/Xmd.h worked for me. This file comes from x11-proto/xproto I pushed the __ILP32__ version of the patch (as in attachment #314459 [details, diff] here) to the x11proto repo.
It should be in xproto-7.0.24 when that gets released.
(I can not predict an ETA.)
Fixed in 7.0.23-r1 |
Created attachment 296445 [details] patch against latest x11-proto/xproto (quite invasive) /bin/sh ../libtool --silent --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I/var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src -I.. -I/var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/include -I/var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/include/X11/Xmu -DBITMAPDIR=\"/usr/include/X11/bitmaps\" -D_BSD_SOURCE -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -Wbad-function-cast -Wformat=2 -Wold-style-definition -Wdeclaration-after-statement -O2 -pipe -c -o ExtAgent.lo /var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src/ExtAgent.c /var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src/EditresCom.c: In function 'HandleToolkitErrors': /var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src/EditresCom.c:998:2: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] /var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src/EditresCom.c: In function '_XEditresGetStringValues': /var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src/EditresCom.c:2198:6: error: duplicate case value /var/tmp/portage/x11-libs/libXmu-1.1.0/work/libXmu-1.1.0/src/EditresCom.c:2194:6: error: previously used here