Summary: | net-libs/libnatpmp-20110808 does not respect LDFLAGS (only --hash-style=gnu) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | New packages | Assignee: | Anthony Basile <blueness> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | esigra |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 331933 | ||
Attachments: |
build.log
libnatpmp-20110808-flags.patch libnatpmp-20110808-r1.ebuild.diff |
Description
Agostino Sarubbo
2011-12-17 08:18:30 UTC
I'm confused about this one because I did not get the QA. Also reading the Makefile, there didn't seem to be anything overriding LDFLAGS. Anyhow, I cleaned up the patch to respect both CFLAGS and LDFLAGS. Here's the test: 1) ebuild libnatpmp-20110808-r1.ebuild clean install gives compiler and linker lines as follows: x86_64-pc-linux-gnu-gcc -O -fPIC -Wall -DENABLE_STRNATPMPERR -O2 -pipe -c -o natpmp.o natpmp.c ... x86_64-pc-linux-gnu-gcc -Wl,-O1 -Wl,--as-needed -o natpmpc-shared natpmpc.o libnatpmp.so 2) CFLAGS="-O0 -ggdb" LDFLAGS="-Wl,-z,relro" ebuild libnatpmp-20110808-r1.ebuild clean install gives compiler lines x86_64-pc-linux-gnu-gcc -O -fPIC -Wall -DENABLE_STRNATPMPERR -O0 -ggdb -c -o natpmp.o natpmp.c ... x86_64-pc-linux-gnu-gcc -Wl,-z,relro -o natpmpc-shared natpmpc.o libnatpmp.s You can see that the CFLAGS and LDFLAGS have been appropriately replaced. I'll leave you to close this one since I couldn't reproduce the error. (Bug 395039 and bug 395043 were trivial fixes so I closed those myself.) Created attachment 296161 [details, diff]
libnatpmp-20110808-flags.patch
Should we merge 3 patches together?
Created attachment 296163 [details, diff]
libnatpmp-20110808-r1.ebuild.diff
Like this...?
(In reply to comment #3) > Created attachment 296163 [details, diff] [details, diff] > libnatpmp-20110808-r1.ebuild.diff > > Like this...? No because each addresses a different issue. Upstream may accept one but not another. I just tested passing CFLAGS="-Wl,--hash-style=gnu" and it works. I'm not sure how to reproduce the original error. Anyhow, I'm closing this because I don't see the issue anymore |