| Summary: | sys-apps/openrc doesn't allow ntp_servers to contain options in net config | ||
|---|---|---|---|
| Product: | Gentoo Hosted Projects | Reporter: | Kevin Bryan <TenToThe8th> |
| Component: | netifrc | Assignee: | netifrc Team <netifrc> |
| Status: | IN_PROGRESS --- | ||
| Severity: | enhancement | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | netifrc:system | ||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Partial patch for ntp_servers as array | ||
Comment on attachment 294203 [details, diff]
Partial patch for ntp_servers as array
sorry, but no. arrays are not allowed anymore as those require bash.
look at how /etc/init.d/net.lo supports multiple options with multiline strings.
The problem with changing this to use newlines, is that we're going to break the configuration for everybody that has no newlines (and users with a mix of newlines and none). We can't easily detect the options either, because there are a lot of different ones, and users DO use hostnames in the ntp_servers variable. I think if users want to use options, they should probably write their own ntp.conf file (there's also no way to set the options from DHCP etc). The only alternative is a new variable name, like ntp2_servers_$IFACE, that's explicitly newline separated. vapier/WilliamH: opinion on making users write their own ntp.conf if they need the options? (In reply to comment #2) > I think if users want to use options, they should probably write their own > ntp.conf file > The issue with writing your own is that it won't change with location. How about:
ntp_config_[iface]="/path/to/ntp.conf.specific"
Given system.sh just creates ntp.conf with a bunch of default values, no reason why we can't instead just cat ${file} > /etc/ntp.conf instead if ${file} exists. And this frees us from having to support who knows what possible config options an end-user might set.
|
Created attachment 294203 [details, diff] Partial patch for ntp_servers as array The ntp_servers* variables in /etc/conf.d/net don't support servers having their own options (such as "key 123456" or "prefer") in ntp.conf. ntp_servers=("ntp1.localdomain key 123456" "ntp2.localdomain key 123457") Here is a partial patch to allow it, although somehow it doesn't work for ntp_servers_WAP, and it does work for ntp_servers_eth1. I assume that it has something to do with an assignment from ntp_servers_WAP to ntp_servers_eth1, but I don't know where that happens.