Bug 392255 – net-analyzer/munin: update fails with /run in tmpfs and migrated /var/run

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2011-11-28 11:03:01 UTC]

With OpenRC 0.9.6 it seems like the intention is to symlink /var/run -> /run .. but that doesn't work very well; indeed /var/run/munin is created by munin-node itself, and it is not created as munin user, so the update script fails badly.

I suppose an alternative would be to make munin part of the uucp group and make it use /run/lock, which is created at each boot with 1775...

[Comment 1 Diego Elio Pettenò (RETIRED) 2011-11-28 11:05:21 UTC]

Okay that's a bad idea as well: on one of my systems it is root:uucp 1775, on another one it's root:uucp 1755 (wth?)... I guess it depends on who creates it.

[Comment 2 Robin Johnson 2011-11-28 16:35:11 UTC]

We need to update all init.d scripts that create subdirs under /var/run, so that they always create them each boot, if /var/run is writable.
If it is not writable, and the dir does not exist, they should bail.

[Comment 3 Diego Elio Pettenò (RETIRED) 2011-11-28 17:53:58 UTC]

The init script already works fine. It's the cron script that fails...

[Comment 4 Jeremy Olexa (darkside) (RETIRED) 2012-07-10 21:34:40 UTC]

  07 Jul 2012; Justin Lecher <[e-mail]> +files/munin-node_init.d_1.4.7,
  +munin-1.4.7-r1.ebuild:
  Add fix when /var/run is on tmpfs

????????

[Comment 5 Justin Lecher (RETIRED) 2012-07-11 05:53:32 UTC]

(In reply to comment #4)
>   07 Jul 2012; Justin Lecher <[e-mail]>
> +files/munin-node_init.d_1.4.7,
>   +munin-1.4.7-r1.ebuild:
>   Add fix when /var/run is on tmpfs
> 
> ????????

oh I didn't checked this bug. 
For me the complete graph creation completely fails.
What I did, was repeating the creation and permission setting from the ebuild inside the init script. Basically what Robin suggested in comment 2. I will add the additional permission check now.

[Comment 6 Justin Lecher (RETIRED) 2012-07-11 06:00:12 UTC]

--- munin-node_init.d_1.4.7       7 Jul 2012 07:21:50 -0000       1.1
+++ munin-node_init.d_1.4.7       11 Jul 2012 05:59:28 -0000
@@ -16,6 +16,9 @@ fix_dirs() {
   local rundir piddir
   piddir=$(dirname ${PIDFILE})
   rundir="/var/run/munin/plugin-state     /var/run/munin/spool"
+ if [[ ! -w "/var/run ]];
+         echo "/var/run is not writable" && exit 1
+ fi
   for dir in ${piddir} ${rundir}; do
           [ -d ${dir} ] || mkdir -p ${dir}
           chown munin:munin ${dir}


Okay in this way?

[Comment 7 Jeremy Olexa (darkside) (RETIRED) 2012-07-11 14:02:23 UTC]

Sure, if it works. What about the cron script (comment #3) ?

[Comment 8 Justin Lecher (RETIRED) 2012-07-11 15:13:50 UTC]

(In reply to comment #7)
> Sure, if it works. What about the cron script (comment #3) ?

I am not sure. Can we run munin without starting the service? Diego?

[Comment 9 Diego Elio Pettenò (RETIRED) 2012-07-11 15:15:35 UTC]

Yes we can, and that's where it failed to me.

[Comment 10 Diego Elio Pettenò (RETIRED) 2012-07-17 14:01:17 UTC]

So I fixed this, hopefully properly, in the 2.0.2 version. Should we backport it or do you think we can close this once we unmask that one?

[Comment 11 Diego Elio Pettenò (RETIRED) 2012-07-20 18:15:53 UTC]

Closing as FIXED as this is handled in 2.0.