Bug 388283 – dev-util/catalyst: removes /etc/portage/ even though sys-apps/portage creates it

• Product: Gentoo Release Media
• Status: RESOLVED FIXED

[Description Brad Normand 2011-10-23 22:23:12 UTC]

/etc/portage/.keep doesn't exist in the stages - it should because it saves a mkdir almost everyone ends up typing at some point.

Reproducible: Always

Steps to Reproduce:
Unpack new stage image.

Actual Results:  
/etc/portage doesn't exist.

Expected Results:  
/etc/portage should be there because otherwise everyone has to make it.

[Comment 1 Jeremy Olexa (darkside) (RETIRED) 2011-10-24 03:05:30 UTC]

What stage are you using? All portage ebuilds do the keepdir..

% grep keepdir /usr/portage/sys-apps/portage/portage-*ebuild
/usr/portage/sys-apps/portage/portage-2.1.10.11.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.1.10.27.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.1.10.29.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.1.10.30.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.1.6.13.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.1.6.7.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.1.9.42.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.2.0_alpha51.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.2.0_alpha67.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.2.0_alpha69.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-2.2.0_alpha70.ebuild:	keepdir /etc/portage
/usr/portage/sys-apps/portage/portage-9999.ebuild:	keepdir /etc/portage

[Comment 2 Jorge Manuel B. S. Vicetto (RETIRED) 2011-10-24 18:19:34 UTC]

From the latest amd64 stage built on my server with the release specs:

$ tar tjvf /home/release/buildroot/amd64-dev/builds/default/stage3-amd64-20111024.tar.bz2 | grep ./etc/portage
$

but

tar xjvf /home/release/buildroot/amd64-dev/builds/default/stage3-amd64-20111024.tar.bz2 ./var/db/pkg/sys-apps/portage-2.1.10.11/CONTENTS
grep /etc/portage var/db/pkg/sys-apps/portage-2.1.10.11/CONTENTS 
dir /etc/portage
obj /etc/portage/.keep_sys-apps_portage-0 d41d8cd98f00b204e9800998ecf8427e 1319430970

looking at catalyst I see:

$ find /home/gentoo-scm/catalyst/ -exec grep -H "/etc/portage" {} \;

/home/gentoo-scm/catalyst/ChangeLog:  Add /etc/portage to cleanables for stages 1 through 3.
/home/gentoo-scm/catalyst/modules/stage3_target.py:             self.settings["cleanables"].extend(["/etc/portage"])
/home/gentoo-scm/catalyst/modules/stage1_target.py:             "/etc/portage"])
/home/gentoo-scm/catalyst/modules/stage2_target.py:             self.settings["cleanables"].extend(["/etc/portage"])

So /etc/portage is being removed by catalyst.

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2011-10-24 18:59:31 UTC]

(In reply to comment #2)

> So /etc/portage is being removed by catalyst.

What is the reason? It should really stop doing that (especially since releng has the mantra that what is built is taken directly from the tree)

[Comment 4 Jorge Manuel B. S. Vicetto (RETIRED) 2011-10-24 23:59:37 UTC]

(In reply to comment #3)
> (In reply to comment #2)
> 
> > So /etc/portage is being removed by catalyst.
> 
> What is the reason? It should really stop doing that (especially since releng
> has the mantra that what is built is taken directly from the tree)

I have no idea why this is being done (it's before my time).
I do agree with you that we should stop doing that. I've poked about this on #gentoo-releng.

@release/catalyst:
Opinions?

[Comment 5 Matt Turner 2011-10-25 00:22:53 UTC]

It's always one of the first things I create to configure newly installed systems. My vote is that we stop removing it.

[Comment 6 Jorge Manuel B. S. Vicetto (RETIRED) 2011-11-06 04:03:22 UTC]

I've committed an update to modules/stage3*.py that should stop catalyst from removing the dir. I'll be testing this on my server tonight.

[Comment 7 Jeremy Olexa (darkside) (RETIRED) 2012-03-06 15:47:50 UTC]

(In reply to comment #6)
> I've committed an update to modules/stage3*.py that should stop catalyst
> from removing the dir. I'll be testing this on my server tonight.

Long since fixed and released. Closing bug