Bug 38822

Summary:	pwdb-0.61-r4.ebuild fails with linux headers 2.4.22
Product:	Gentoo Linux	Reporter:	John Kelly <a23d56>
Component:	[OLD] Core system	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	blocker
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	my patch

Description John Kelly 2004-01-20 07:52:13 UTC

pwdb Makefile includes -ansi warning flag and thus gcc does not recognize C++ style comments in linux 2.4.22 header file

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1 John Kelly 2004-01-20 07:54:07 UTC

Created attachment 24132 [details, diff]
my patch

Comment 2 John Kelly 2004-01-20 07:55:43 UTC

Comment on attachment 24132 [details, diff]
my patch

-ansi warning flag is not needed, use sed to strip it out of Makefile

Comment 3 SpanKY gentoo-dev

2004-04-06 11:59:01 UTC

does pwdb-0.62 fail for you ?

Comment 4 John Kelly 2004-04-25 16:44:07 UTC

I no longer use linux headers 2.4.22, so I don't know whether it fails or not. The problem happens because some people are using C++ comments in kernel patches; any package, like pwdb for example, which specifies the -ansi warning flag in the makefile, will have this same problem when including a kernel header file having any // C++ style commnets.

Using // comments in a kernel header is a bad, sloppy habit; the kernel will never be C++. But since I'm using a 2.6.5 win4lin kernel now, and it has no gentoo patches, I'm no longer afftected.