Summary: | media-gfx/gtkimageview: awkward configure.in adds unuseful dependency to gnome-common | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Samuel Bauer <samuel.bauer> |
Component: | New packages | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED INVALID | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | autobuilds | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
pre-version not inheriting gnome2
gtkimageview-1.6.4-r1.ebuild gtkimageview-1.6.4-gnome-common.patch |
Description
Samuel Bauer
2011-10-21 05:50:49 UTC
Created attachment 290405 [details]
pre-version not inheriting gnome2
The ebuild compile but it's just sample
it doesn't install the gtk-doc entries
it doesn't install the sample files
gnome-common is set of .m4 macros for autotools, and the gtkimageview's configure.ac has: # Initialize GNOME environment GNOME_COMMON_INIT and the ebuild calls eautoreconf for patches thus this bug is invalid, and the dependency is required Created attachment 291341 [details] gtkimageview-1.6.4-r1.ebuild Do not use GNOME_COMMON_INIT, as it does not work with autoreconf. See: http://live.gnome.org/GnomeGoals/ModernAutotools Take a look at the src_prepare it's easy to understand that the configure.in is broken (already two fix without the one I suggest) Any progress on this? There's a fixed ebuild attached to this bug already. Due to this bug, emerging imagemagick with USE="raw gtk" pulls in gnome-common (through gtkimageview) for no apparent reason. This is INVALID, gnome2.eclass has nothing to do with gnome-common requirement Created attachment 449780 [details, diff]
gtkimageview-1.6.4-gnome-common.patch
This is unrelated to gnome2.eclass, even my local overlay wasn't throwing it, before I updated it yesterday, seeing changes in the tree.
But still the GNOME_COMMON_INIT line seem to be a waste
Trying to emerge the new patched ebuild version:
emerge -C gnome-common
emerge gtkimageview -1
Ensures that gnome common isn't installed, is not pushed through emerge, and still doesn't complain nor at compile time, nor at runtime.
Removing GNOME_COMMON_INIT line just removes the dependency.
So it doesn't appear to be mandatory dependency.
Upstream is the one that should consider all the gnome-common functionality can be replaced by others (dropping gnome-common macros is not as easy as simply dropping its usage and go on... that is the reason you still see tons of packages still DEPENDing on gnome-common waiting for someone to port them to, for example, autoconf-archive macros for "similar" functionality |