Bug 387779

Summary:	sys-auth/polkit: gtk use flag is used for non-gtk dependencies
Product:	Gentoo Linux	Reporter:	Samuel Bauer <samuel.bauer>
Component:	New packages	Assignee:	Nirbheek Chauhan (RETIRED) <nirbheek>
Status:	RESOLVED INVALID
Severity:	normal	CC:	comrel, freedesktop-bugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Samuel Bauer 2011-10-20 05:18:59 UTC

The gtk flag for polkit add dependencies those dependencies

gtk? ( || ( >=gnome-extra/polkit-gnome-0.101 lxde-base/lxpolkit ) )

those dependencies are clearly unrelated with the gtk toolkit.
there are merely related on gtk-based desktop environment.

I propose:
1/ rename and split flag: lxde, gnome
gnome? ( >=gnome-extra/polkit-gnome-0.101 )
!gnome? ( lxde? ( lxde-base/lxpolkit ) )

2/ document the flag in metadata.xml

Second proposal is just an easy workaround.

Reproducible: Couldn't Reproduce

Actual Results:  
gtk flag adds dependency to desktop environment components

Expected Results:  
gtk flag shouldn't add dependency to desktop environment components

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2011-10-20 12:47:32 UTC

The dependencies are clearly only GTK+ specific with nothing more than GTK+ and polkit in dependencies, used by *any* XDG /etc/xdg/autostart supporting desktop.

Comment 2 Samuel Bauer 2011-10-21 04:04:42 UTC

(In reply to comment #1)
> The dependencies are clearly only GTK+ specific with nothing more than GTK+ and
> polkit in dependencies, used by *any* XDG /etc/xdg/autostart supporting
> desktop.

So we are speaking about desktop, not about toolkit, then why the flag is named as the toolkit not the desktop environment ?

The ebuild got a kde flag, why isn't it named qt or qt4? Because it's not related to the window toolkit but to the desktop environment (even the desktop environment is based on the toolkit).

	kde? ( || ( sys-auth/polkit-kde-agent sys-auth/polkit-kde ) )

The kde and qt flags fits well to their respective usage, where the gnome(,lxde) and gtk flag are confused in many ebuilds

Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev

2011-10-21 07:03:13 UTC

The gtk flag is used to any gtk desktop (gnome, xfce, lxde, ...). There's no point in having 3 USE flags for the same action on a simple ebuild like this. KDE guys are "lucky" to only have one desktop to care about, that's all.

Comment 4 Samuel Bauer 2011-10-21 08:18:29 UTC

The point isn't to know if KDE guy's are lucky or not.
The main point is that gtk flag shouldn't be used for gnome dependencies.

One user should be able to skip the sync of categories gnome-* when he adds -gnome to his useflags.

One can do it with lxde-*, gpe-*, xfce-*, or kde-*, but not with gnome-*

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2011-10-21 12:52:06 UTC

(In reply to comment #4)
> The point isn't to know if KDE guy's are lucky or not.
> The main point is that gtk flag shouldn't be used for gnome dependencies.

it's not gnome dependency, it's GTK+ policykit authentication agent, not specific to gnome at all, it's for everything else *except* KDE just like the installed XDG .desktop autostart entry implies: 

NotShowIn=KDE;

> One user should be able to skip the sync of categories gnome-* when he adds
> -gnome to his useflags.

untrue, gnome categories include important components like librsvg, used by even headless machines through gdk-pixbuf, for eg. imagemagick
would be pretty stupid move to exclude them.

> One can do it with lxde-*, gpe-*, xfce-*, or kde-*, but not with gnome-*

unrelated to this bug

don't reopen again