Bug 386555 – webapp.eclass: ebeep is used with EAPI=4

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Nico Baggus 2011-10-09 17:21:02 UTC]

>>> Emerging (5 of 5) www-apps/moodle-2.1.2
 * moodle-2.1.2.tgz RMD160 SHA1 SHA256 size ;-) ...                                                                                                          [ ok ]

 * 
 * You already have something installed in //var/www/localhost/htdocs/moodle
 * 
 * Whatever is in //var/www/localhost/htdocs/moodle, it's not
 * compatible with webapp-config.
 * 
 * This ebuild may be overwriting important files.
 * 

 * QA Notice: ebeep is not defined in EAPI=4, please file a bug at http://bugs.gentoo.org


Besides that the earlier warning is queeer as the previous install was done using webapp-config.

[Comment 1 Peter Volkov (RETIRED) 2011-10-11 04:52:13 UTC]

Actually webapp.eclass was never supposed to work with EAPI>1...

[Comment 2 Doug Goldstein (RETIRED) 2012-07-13 16:05:56 UTC]

(In reply to comment #1)
> Actually webapp.eclass was never supposed to work with EAPI>1...

Well it should probably block that case then.

[Comment 3 Anthony Basile 2012-07-13 19:08:15 UTC]

(In reply to comment #2)
> (In reply to comment #1)
> > Actually webapp.eclass was never supposed to work with EAPI>1...
> 
> Well it should probably block that case then.

Or I could just remove ebeep and move towards making webapp.eclass EAPI=4 compat.

[Comment 4 Doug Goldstein (RETIRED) 2012-07-15 22:44:35 UTC]

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Actually webapp.eclass was never supposed to work with EAPI>1...
> > 
> > Well it should probably block that case then.
> 
> Or I could just remove ebeep and move towards making webapp.eclass EAPI=4
> compat.

That's what I would prefer as well. I committed the following fix to resolve this. This doesn't mean I want to maintain this eclass, it just means it was a simple fix.

diff -u -B -r1.70 webapp.eclass
--- webapp.eclass       27 Dec 2011 17:55:12 -0000      1.70
+++ webapp.eclass       15 Jul 2012 22:43:54 -0000
@@ -413,7 +413,9 @@
                ewarn "This ebuild may be overwriting important files."
                ewarn
                echo
-               ebeep 10
+               if has "${EAPI:-0}" 0 1 2 3; then
+                       ebeep 10
+               fi
        elif [[ "$(echo ${my_output} | awk '{ print $1 }')" != "${PN}" ]]; then
                echo
                eerror "You already have ${my_output} installed in ${my_dir}"

[Comment 5 Anthony Basile 2012-07-16 13:08:06 UTC]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > Actually webapp.eclass was never supposed to work with EAPI>1...
> > > 
> > > Well it should probably block that case then.
> > 
> > Or I could just remove ebeep and move towards making webapp.eclass EAPI=4
> > compat.
> 
> That's what I would prefer as well. I committed the following fix to resolve
> this. This doesn't mean I want to maintain this eclass, it just means it was
> a simple fix.
> 

NP.  I'm kinda sorta maintaining the eclass because I'm maintaining webapp-config, but it needs more work than I have time for.  Every bit of help is welcome.

[Comment 6 Anthony Basile 2012-07-18 14:57:26 UTC]

Actually I get:

 * QA Notice: ebeep is not defined in EAPI=3, please file a bug at http://bugs.gentoo.org


So I'm going to change to

    if has "${EAPI:-0}" 0 1 2; then


I think this bug is done.  Please reopen if there's any more problems.