Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 38563

Summary: haskell-mode's init file does too much
Product: Gentoo Linux Reporter: Peter Simons <simons>
Component: New packagesAssignee: Emacs project <emacs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Peter Simons 2004-01-17 17:58:35 UTC
The file 50haskell-mode-gentoo.el installed by haskell-mode contains, among other things, these directives:

  (add-hook 'haskell-mode-hook 'turn-on-haskell-font-lock)
  (add-hook 'haskell-mode-hook 'turn-on-haskell-decl-scan)
  (add-hook 'haskell-mode-hook 'turn-on-haskell-doc-mode)
  (add-hook 'haskell-mode-hook 'turn-on-haskell-indent)
  (add-hook 'haskell-mode-hook 'turn-on-haskell-simple-indent)
  (add-hook 'haskell-mode-hook 'turn-on-haskell-hugs)

IMHO it's not a good idea to add all these here. The haskell-mode is a bit shaky when it comes to changing the configuration. It's hard for a user (like me) to "un-add" any of these hooks. So if I don't want to run the, say, decl-scan feature, I have to edit the file to remove the line! This is bound to create problems when updating to a new version.

Maybe it would be best to keep the code in there but to comment it out, telling te user to add the appropriate directives in a file of his own?

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Jeremy Maitin-Shepard 2004-01-18 09:48:06 UTC
Fixed in CVS.

Because those customizations are mentioned in the installation documentation, and the ebuild already suggests that the user refer to it, I see no need to even include them commented in the site file.