Bug 385121

Summary:	media-video/ogmrip refuses to install due to "poor programming practices"
Product:	Gentoo Linux	Reporter:	Christian Authmann <christian>
Component:	Current packages	Assignee:	Olivier Rolland <billl>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	media-video, proxy-maint, rossi.f
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	logfile from failed build output of emerge --info =media-video/ogmrip-0.13.6 ogmrip-0.13.6-deprecated.patch ogmrip-0.13.6-deprecated.patch ogmrip-0.13.6-deprecated.patch

Description Christian Authmann 2011-09-30 19:22:28 UTC

Created attachment 288401 [details]
logfile from failed build

emerge media-video/ogmrip fails:

[ebuild  N    ] media-video/ogmrip-0.13.6  USE="aac dbus dts gtk matroska mp3 mp4 nls spell theora vorbis x264 xvid -libnotify -ogm -srt" 

Seems to compile fine up the the point where binaries get stripped, but then refuses to install due to this message:

 * QA Notice: Package has poor programming practices which may compile
 *            but will almost certainly crash on 64bit architectures.
 * 
 * Function `gtk_combo_box_new_text' implicitly converted to pointer at ogmrip-source-chooser-widget.c:210
 * 
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.
 * 
 * ERROR: media-video/ogmrip-0.13.6 failed:
 *   install aborted due to poor programming practices shown above

Comment 1 Christian Authmann 2011-09-30 19:23:04 UTC

Created attachment 288403 [details]
output of emerge --info =media-video/ogmrip-0.13.6

Comment 2 Olivier Rolland 2011-10-09 18:27:25 UTC

Created attachment 289395 [details, diff]
ogmrip-0.13.6-deprecated.patch

This patch fixes this issue.

(The error message is quite funny : the real error has nothing to do with 'implicitly converted pointer' but with deprecated API in GTK+).

Comment 3 Fabio Rossi 2011-10-25 19:04:34 UTC

The patch works for me

Comment 4 Olivier Rolland 2011-10-27 17:34:17 UTC

Created attachment 291021 [details, diff]
ogmrip-0.13.6-deprecated.patch

This new patch also replaces G_CONST_RETURN with const.

Comment 5 Olivier Rolland 2011-11-12 17:23:29 UTC

Created attachment 292305 [details, diff]
ogmrip-0.13.6-deprecated.patch

This new patch fixes some issues introduced by the previous one regarding profile creation/edition and frame extraction when cropping manually.

Comment 6 Pacho Ramos gentoo-dev

2015-01-17 22:31:55 UTC

fixed in 1.0.1