Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 385005

Summary: [gnome-overlay] net-misc/vinagre-3.2.0 install aborted due to poor programming practices
Product: Gentoo Linux Reporter: Jason Lamb <jason>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://bugzilla.gnome.org/show_bug.cgi?id=660531
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge --info
net-misc/vinagre-3.2.0 build log

Description Jason Lamb 2011-09-29 22:18:30 UTC
Created attachment 288281 [details]
emerge --info

Trying to emerge net-misc/vinagre-3.2.0 from the gnome overlay, fails the
install phase every time with the QA Notice: `Package has poor programming practices which may compile fine but exhibit random runtime failures.`
Comment 1 Jason Lamb 2011-09-29 22:19:08 UTC
Created attachment 288283 [details]
net-misc/vinagre-3.2.0 build log
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-09-29 22:51:07 UTC
Confirming, looks like the build system is not generating the needed headers from the vala files. Should be easy to fix.
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-09-30 02:50:46 UTC
Fixed in vinagre-3.2.0-r1 in the overlay, thanks for reporting!

> commit 32ff15f9d24355f92950624c2a0b9d5b3f80c0e4
> Author: Alexandre Rostovtsev <tetromino@gmail.com>
> Date:   Thu Sep 29 22:44:10 2011 -0400
> 
> net-misc/vinagre: fix implicit function declarations (#385005)
>     
> Fix numerous implicit function declarations in vinagre-3.2.0 by
> generating a missing header from vala source, using non-deprecated gtk
> functions, and adding necessary #include statements in various files.
> Thanks to Jason Lamb <jason@lambhome.org> for reporting (bug #385005).
>     
> Patch submitted upstream at https://bugzilla.gnome.org/show_bug.cgi?id=660531