Bug 384533 – >=gnome-base/gnome-panel-2.32 fails because of underlinking

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Naohiro Aota 2011-09-26 15:13:21 UTC]

Created attachment 287797 [details]
build.log

Seems the package has underlinking problem.

cf. 

> Hello there!

> You're getting this bug because the package in Summary failed to build in my
> tinderbox using the gold link editor from binutils. Before closing the bug as
> INVALID let me explain why this is still important!

> The gold link editor does not support underlinking of shared objects, which is
> something I have described in my blog post:

> http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

> Even the basic link editor (ld.bfd) has an option to support this but it is a
> heck to enable and get passed, so linking with gold is simply quicker.

> Fixing underlinking provides optimized --as-needed builds (because the "softer"
> version no longer need to recover libraries that are underlinked), so it is a
> Good Thing To Do.

> Thank you very much for the attention!

[Comment 1 Pacho Ramos 2011-09-26 15:29:55 UTC]

Feel free to report this to upstream, but maybe one of the following patches fix your problem:
http://git.gnome.org/browse/gnome-panel/commit/?id=d38428d78ca5a3e51e0cf472875652fd2d787ada
http://git.gnome.org/browse/gnome-panel/commit/?id=787dc4c9b1d433829de03b6c89df3a748bddc31d

[Comment 2 Naohiro Aota 2011-09-26 16:02:42 UTC]

Created attachment 287803 [details, diff]
sample fix

This is a example patch to fix this underlinking problem. I've confirmed the package build well with this patch and ld.gold. 

But somewhat better solutions (using configure.ac?) would be possible.

[Comment 3 Naohiro Aota 2011-09-27 04:10:01 UTC]

(In reply to comment #1)
> Feel free to report this to upstream, but maybe one of the following patches
> fix your problem:
> http://git.gnome.org/browse/gnome-panel/commit/?id=d38428d78ca5a3e51e0cf472875652fd2d787ada
> http://git.gnome.org/browse/gnome-panel/commit/?id=787dc4c9b1d433829de03b6c89df3a748bddc31d

These commit doesn't solve the problem. I'll report this to upstream.

[Comment 4 Matt Turner 2012-10-16 01:35:56 UTC]

I've hit this too when doing bug 427544. Do I understand correctly that this bug has been known, with the fix known, and patch made,  but untouched for more than a year?!

[Comment 5 Alexandre Rostovtsev (RETIRED) 2012-10-16 03:56:37 UTC]

(In reply to comment #4)
Thanks for the reminder; fixed in cvs.

> Do I understand correctly that this
> bug has been known, with the fix known, and patch made,  but untouched for
> more than a year?!

I suspect that Pacho was thinking that the underlinking issue was also present in gnome-panel-3, so he was waiting for upstream to patch it so he could backport the patch to 2.32.1. But it seems that the underlinked libm-using code was simply removed in gnome-panel-3, and upstream doesn't care about build issues only in gnome-panel-2.

>  16 Oct 2012; Alexandre Rostovtsev <[e-mail]>
>  -gnome-panel-2.32.1-r1.ebuild, -gnome-panel-2.32.1-r2.ebuild,
>  gnome-panel-2.32.1-r3.ebuild, +files/gnome-panel-2.32.1-underlinking.patch,
>  gnome-panel-3.2.1.ebuild, -gnome-panel-3.4.1.ebuild,
>  gnome-panel-3.4.2.1.ebuild:
>  Fix linking failure with gold (bug #384533, thanks to Naohiro Aota). Drop
>  useless USE=doc, it only regenerated documentation. Update license. Drop old.

[Comment 6 Pacho Ramos 2012-10-16 17:42:15 UTC]

I left it because my setup doesn't have gold linker to know if the patch really works or not and, if I don't misremember, I suggest last developer reporting this kind of bugs + patch + report to upstream to commit them if they are able to test

[Comment 7 Pacho Ramos 2012-10-16 17:42:38 UTC]

(In reply to comment #6)
> I left it because my setup doesn't have gold linker to know if the patch
> really works or not and, if I don't misremember, I suggest last developer
> reporting this kind of bugs + patch + report to upstream to commit them if
> they are able to test

suggest -> suggested