Bug 384087 – net-misc/dhcp-4.2.2-r2 installs bogus default dhclient.conf

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Nick Bowler 2011-09-22 14:36:21 UTC]

Created attachment 287413 [details]
Installed default dhclient configuration file.

The recently stabilised net-misc/dhcp-4.2.2-r2 installs a default dhclient.conf
which is probably not suitable for any domain.  The results are that dhclient
is essentially broken by default, because it contains wonderful lines like

  supersede domain-search "fugue.com", "home.vix.com".

which overrides the actual search domain sent by the DHCP server, and

  prepend domain-name-servers 127.0.0.1

among a number of other options.  The bogus config file is attached for
reference.  The result is that upgrading from dhcp-3.1.3_p1 to dhcp-4.2.2-r2
breaks the boot on my system, because DNS resolution is not working correctly.

Deleting /etc/dhcp/dhclient.conf resolves the issue, but it will presumably be
replaced at the next upgrade of the dhcp package.

Previous versions of the dhcp package installed the example configs with a
".sample" suffix, so that they wouldn't actually be used.  If the file must
be installed to /etc/dhcp/dhclient.conf, the example directives should at least
be commented out.

Portage 2.1.10.11 (default/linux/amd64/10.0, gcc-4.4.5, glibc-2.12.2-r0, 3.1.0-rc7 x86_64)
=================================================================
System uname: Linux-3.1.0-rc7-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q8300_@_2.50GHz-with-gentoo-2.0.3
Timestamp of tree: Thu, 22 Sep 2011 00:45:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 2.4 [enabled]
app-shells/bash:          4.1_p9
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.1-r1, 3.1.3-r1
dev-util/ccache:          2.4-r9
dev-util/cmake:           2.8.4-r1
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.8.3-r1
sys-apps/sandbox:         2.4
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            3.4.6-r2, 4.1.2, 4.2.4-r1, 4.4.5, 4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.36.1 (virtual/os-headers)
sys-libs/glibc:           2.12.2
Repositories: gentoo gentoo-draconx
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=core2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=core2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y"
FEATURES="assume-digests binpkg-logs ccache distlocks ebuild-locks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch webrsync-gpg"
FFLAGS=""
GENTOO_MIRRORS="ftp://mirror.datapipe.net/gentoo"
LANG="en_CA.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en_CA en ja"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl alsa amd64 berkdb bzip2 cairo cjk cli cracklib crypt cups curl cvs cxx doc dri enca exif fbcon ffmpeg flac fontconfig fontforge fortran gdbm gpm graphviz gtk iconv icu idn imagemagick ipv6 jadetex jpeg kpathsea latex lcms mmx modules mp3 mudflap multilib ncurses nls nptl nptlonly ogg opengl openmp otr pam pcre perl png postgres pppd python qt3support readline sdl session smp sse sse2 sse3 ssl ssse3 svg sysfs tcpd tex4ht theora threads tiff truetype unicode vim-syntax vorbis xcb xft xinerama xorg xulrunner xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_CA en ja" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="intel fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 SpanKY 2011-09-22 17:44:13 UTC]

looking at the history, i'm pretty sure the default dhclient.conf has never really be usable out of the box.  the newer version seems to be a little bit "worse", but i wouldn't truly call it a regression.

[Comment 2 Nick Bowler 2011-09-22 17:49:38 UTC]

(In reply to comment #1)
> looking at the history, i'm pretty sure the default dhclient.conf has never
> really be usable out of the box.  the newer version seems to be a little bit
> "worse", but i wouldn't truly call it a regression.

net-misc/dhcp-3.1.3_p1 does not install any default dhclient.conf *at all*.

[Comment 3 SpanKY 2011-09-22 18:58:18 UTC]

yes, it did.  it however used a ".sample" suffix.  sample files don't belong in the /etc tree though.

[Comment 4 SpanKY 2011-09-22 19:38:53 UTC]

should be all set now in the tree; thanks for the report!

Commit message: Install the default config files commented out since they aren't useful in the real world other than as examples
http://sources.gentoo.org/net-misc/dhcp/dhcp-4.2.2-r2.ebuild?r1=1.4&r2=1.5
http://sources.gentoo.org/net-misc/dhcp/files/dhcpd.init4?r1=1.1&r2=1.2