Summary: | app-emulation/xen-tools-3.4.2-r1 fails to compile with gcc-4.5.3-r1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Ian Delaney (RETIRED) <idella4> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chainsaw, xen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 379241 | ||
Attachments: |
build.log
patch for xen-tools-3.4.2-r2 xen-tools-3.4.2-werror-idiocy.patch |
Description
Agostino Sarubbo
2011-09-21 16:15:06 UTC
The point to 3.4.2 but is same thing with r1 I check and the problem is only with gcc-4.5 After discussion with idella4 in #gentoo-dev-help, it seems that due to the recent gcc-4.5 stabilization, the -Werror flag which is appended to all the various Makefiles in the source is the culprit. Further, there seems to be no autotools-based build system or other Makefile generator. As version 3 stuffs is not being released upstream, adding another sed rule to the list of already-existing rules for USE="custom-cflags", to strip -Werror out of all the Makefiles, seems to be the best option to move forward. Created attachment 287511 [details, diff]
patch for xen-tools-3.4.2-r2
Fixes
+*xen-tools-3.4.2-r2 (23 Sep 2011) + + 23 Sep 2011; Tony Vroon <chainsaw@gentoo.org> -xen-tools-3.4.2-r1.ebuild, + +xen-tools-3.4.2-r2.ebuild, +files/xen-tools-3.4.2-werror-idiocy.patch: + Patch by Ian "idella4" Delaney to clear -Werror, stopping GCC 4.5 build + failures. Closes bug #383977. Moved to using a PATCHES array and the base + eclass. Created attachment 287539 [details, diff]
xen-tools-3.4.2-werror-idiocy.patch
The previous ?? had too much taken out, appears to fail. This one works here
Fails as precedent revision amd64box ~ # qlop -s Fri Sep 23 21:39:10 2011 >>> rsync://134.68.240.58/gentoo-portage qlop -s Sat Sep 24 01:43:39 2011 >>> rsync://136.186.1.76/gentoo-portage the package is now xen-tools-3.4.2-r2. If it fails, swap the xen-tools-3.4.2-werror-idiocy.patch with the one in Comment 6. Believe me, it can compile archtester xen-tools # ebuild xen-tools-3.4.2-r2.ebuild compile >>> Remove '/mnt/gen2/tmpdir/portage/app-emulation/xen-tools-3.4.2-r2/.compiled' to force compilation. >>> Emerging (1 of 1) app-emulation/xen-tools-3.4.2-r2 * xen-3.4.2.tar.gz RMD160 SHA1 SHA256 size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking xen-3.4.2.tar.gz to /tmp/portage/app-emulation/xen-tools-3.4.2-r2/work >>> Source unpacked in /tmp/portage/app-emulation/xen-tools-3.4.2-r2/work >>> Preparing source in /tmp/portage/app-emulation/xen-tools-3.4.2-r2/work/xen-3.4.2 ... * Applying xen-tools-3.4.0-network-bridge-broadcast.patch ... [ ok ] * Applying xen-tools-3.3.0-nostrip.patch ... [ ok ] * Applying xen-tools-3.3.1-sandbox-fix.patch ... [ ok ] * Applying xen-tools-3.4.2-as-needed.patch ... [ ok ] * Applying xen-tools-3.4.2-fix-definitions.patch ... [ ok ] * Applying xen-tools-3.4.2-fix-include.patch ... [ ok ] * Applying xen-tools-3.4.2-werror-idiocy.patch ... [ ok ] [.................] cc1: warnings being treated as errors xs_lib.c: In function ‘xs_perm_to_string’: xs_lib.c:159:2: error: case value ‘3’ not in enumerated type ‘const enum xs_perm_type’ make[2]: *** [xs_lib.opic] Errore 1 make[2]: *** Attesa dei processi non terminati.... make[2]: Leaving directory `/tmp/portage/app-emulation/xen-tools-3.4.2-r2/work/xen-3.4.2/tools/xenstore' make[1]: *** [subdir-all-xenstore] Errore 2 make[1]: Leaving directory `/tmp/portage/app-emulation/xen-tools-3.4.2-r2/work/xen-3.4.2/tools' make: *** [subdirs-all] Errore 2 make: Leaving directory `/tmp/portage/app-emulation/xen-tools-3.4.2-r2/work/xen-3.4.2/tools' emake failed It _still_ fails. archtester xen-tools # ebuild xen-tools-3.4.2-r2.ebuild clean compile cc1: warnings being treated as errors xs_lib.c: In function ‘xs_perm_to_string’: xs_lib.c:159:2: error: case value ‘3’ not in enumerated type ‘const enum xs_perm_type’ Sadly that version of the committed patch is bad. "If it fails, swap the xen-tools-3.4.2-werror-idiocy.patch with the one in Comment 6", discovered all last night. # cd $PORTDIR/app-emulation/xen-tools/ # repoman manifest. # ebuild xen-tools-3.4.2-r2.ebuild clean compile (In reply to comment #10) > Sadly that version of the committed patch is bad. > "If it fails, swap the xen-tools-3.4.2-werror-idiocy.patch with the one in > Comment 6", discovered all last night. Which still causes: fsys_zfs.c: In function ‘zio_read’: fsys_zfs.c:349:15: error: variable ‘cksum’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors As discussed. I will not commit further patches until they stop failing. Please try again. +*xen-tools-3.4.2-r3 (24 Sep 2011) + + 24 Sep 2011; Tony Vroon <chainsaw@gentoo.org> -xen-tools-3.4.2-r2.ebuild, + +xen-tools-3.4.2-r3.ebuild, -files/xen-tools-3.4.2-werror-idiocy.patch, + +files/xen-tools-3.4.2-werror-idiocy-v2.patch: + Revised patch by Ian "idella4" Delaney resolves building on GCC 4.5 & 4.6; + closes bug #383977. |