Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 383883

Summary: app-backup/duply - duply (grown out of ftplicity) is a shell frontend for duplicity
Product: Gentoo Linux Reporter: Marcel Pennewiß <gentoo>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED FIXED    
Severity: enhancement CC: gentoo, matija, proxy-maint, tobias.pal, vanquirius
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://duply.net
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: duply-1.5.5.1.ebuild
duply-1.5.5.1-r1.ebuild
duply-1.5.9.ebuild
duply-1.5.10.ebuild
duply-1.7.3.ebuild
duply-1.7.3.ebuild

Description Marcel Pennewiß 2011-09-21 05:15:46 UTC
new ebuild

Reproducible: Always
Comment 1 Marcel Pennewiß 2011-09-21 05:16:54 UTC
Created attachment 287233 [details]
duply-1.5.5.1.ebuild
Comment 2 Marcel Pennewiß 2011-09-21 05:22:56 UTC
Created attachment 287237 [details]
duply-1.5.5.1-r1.ebuild

same as duply-1.5.5.1.ebuild with useflags for duplicity (see Bug 383881)
Comment 3 Matija "hook" Šuklje 2013-03-01 19:04:30 UTC
1.5.9 is released.
Comment 4 Marcel Pennewiß 2013-03-01 19:28:44 UTC
I'm willing to maintain via proxy-maintainer... ;)
Comment 5 Matija "hook" Šuklje 2013-03-01 21:12:28 UTC
(In reply to comment #4)
> I'm willing to maintain via proxy-maintainer... ;)

I assume that means that your so far written ebuilds work as expected for you?
Comment 6 Marcel Pennewiß 2013-03-01 22:32:42 UTC
Created attachment 340712 [details]
duply-1.5.9.ebuild

new version
Comment 7 Marcel Pennewiß 2013-03-01 22:33:39 UTC
(In reply to comment #5)
> I assume that means that your so far written ebuilds work as expected for
> you?

i use my ebuild in our private overlay and on several machines, so: yes ;) ebuild is very simple, no magic anywhere.
Comment 8 Matija "hook" Šuklje 2013-03-02 00:07:40 UTC
(In reply to comment #6)
> Created attachment 340712 [details]
> duply-1.5.9.ebuild
> 
> new version

Emerges fine on ARCH="amd64" and ARCH="arm" and at least `duply --help` and `duply create` work.

I think you can safely add ARCH="~arm" to the ebuild, before it gets added to official tree.
Comment 9 Philip Taffner 2013-04-18 16:38:34 UTC
Created attachment 345916 [details]
duply-1.5.10.ebuild

New version.
Comment 10 Marcel Pennewiß 2014-04-10 16:14:58 UTC
Created attachment 374698 [details]
duply-1.7.3.ebuild

Version bump
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2014-04-12 10:28:29 UTC
(In reply to Marcel Pennewiß from comment #10)
> Created attachment 374698 [details]
> duply-1.7.3.ebuild
> 
> Version bump

A few comments

- The description must not contain the package name. How about changing that to "A shell frontend for duplicity" (not dot at the end)

- Is app-backup/duplicity really a build time dependency? or is it just a runtime one?

- in src_install you can replace 'duply' with ${PN}
- Why are you installing the INSTALL.txt file? the package is already installed so what useful information could be in that txt file for the user? I suggest to install a ChangeLog and/or README file (if any).
- in pkg_postinst() maybe you can benefit from the readme.gentoo.eclass to avoid spamming the log on every build?
Comment 12 Marcel Pennewiß 2014-04-12 17:58:32 UTC
(In reply to Markos Chandras from comment #11)
> - The description must not contain the package name. How about changing that
> to "A shell frontend for duplicity" (not dot at the end)

fixed.

> - Is app-backup/duplicity really a build time dependency? or is it just a
> runtime one?

it is a running dependency. fixed.

> - in src_install you can replace 'duply' with ${PN}

fixed also in Log-Message.

> - Why are you installing the INSTALL.txt file? the package is already
> installed so what useful information could be in that txt file for the user?
> I suggest to install a ChangeLog and/or README file (if any).

indeed ;) There's no Changelog in Upstream-Archive. If we'll deliver a Changelog we have to deliver a readme.txt (14.7kb and there's only one for all 1.7.x-versions) with the portage. Otherwise if 1.7.4. will be released, the upstream readme.txt will be changed in 1.7.x-tree and this package will break. that's not good ;) Now there's no Changelog in ebuild/filesdir.

> - in pkg_postinst() maybe you can benefit from the readme.gentoo.eclass to
> avoid spamming the log on every build?

I didn't know about that, nice feature. Added to ebuild.
Comment 13 Marcel Pennewiß 2014-04-12 17:58:56 UTC
Created attachment 374828 [details]
duply-1.7.3.ebuild
Comment 14 Markos Chandras (RETIRED) gentoo-dev 2014-04-13 10:19:54 UTC
+*duply-1.7.3 (13 Apr 2014)
+
+  13 Apr 2014; Markos Chandras <hwoarang@gentoo.org> +duply-1.7.3.ebuild,
+  +metadata.xml:
+  Initial commit. Bug #383883. Thanks to Marcel Pennewiß <gentoo@pennewiss.de>
+  who will proxy-maintain it
+