Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 383363

Summary: media-video/ogmrip-0.13.6 needs threads patch to enable multithreading
Product: Gentoo Linux Reporter: godmachine (Lance Poore) <linuxsociety>
Component: [OLD] UnspecifiedAssignee: Olivier Rolland <billl>
Severity: enhancement CC: linuxsociety, media-video, proxy-maint
Priority: High    
Version: 10.1   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Attachments: ogmrip-0.13-threads.patch

Description godmachine (Lance Poore) 2011-09-17 15:32:42 UTC
The ogmrip-0.13.6 ebuild doesn't contain the patch that enables threading to multiple cores.  I am attaching the patch

Reproducible: Always

Steps to Reproduce:
1.emerge media-video/ogmrip
2.Run omgrip and Open Preferences thread option available, noticeable when encoding on multiple core cpu.
Actual Results:  
Only 1 cpu thread was enabled, resulting in a slow encoding process

Expected Results:  
User should be able to select the preferred amount of threads based on their cpu
Comment 1 godmachine (Lance Poore) 2011-09-17 15:33:39 UTC
Created attachment 286781 [details, diff]
Comment 2 Olivier Rolland 2011-09-19 18:14:12 UTC
That's not exactly true : threading to multiple cores is available in 0.13.6 but not configurable. This patch makes it configurable.
Comment 3 godmachine (Lance Poore) 2011-09-19 18:40:01 UTC
(In reply to comment #2)
funny thing that ogmrip-0.13.6 was only using 1 core (monitored by htop)  when running without the patch.. After patching, it does make it configurable, but also sets the appropriate number of cores automatically, and after doing so I could monitor with htop and see all cores in use by ogmrip, maybe it was lying before?
Comment 4 Olivier Rolland 2011-09-19 18:57:43 UTC
Then I suppose there was a bug. Anyway feel free to apply the patch, it's already in OGMRip's subversion.
Comment 5 Sven Vermeulen (RETIRED) gentoo-dev 2014-05-02 19:48:07 UTC
I confirm that ogmrip-0.13.8 contains the thread patch; closing this as FIXED.