Bug 383237 – app-shells/bash-4.2_p10 fails to build with job control disabled

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Maciej Grela 2011-09-16 14:32:48 UTC]

When cross-compiling bash-4.2_p10 job control is disabled causing a failure to compile as one of the places using the job_compile variable is not protected by an #ifdef

I've posted this problem to the bash mailing list and got back info that it will be fixed in bash-4.3. As it's not released yet I'm sending a patch to fix this in the bash currently in tree.


Reproducible: Always

Steps to Reproduce:
1. crossdev -t hppa
2. hppa-unknown-linux-gnu-emerge bash
3.
Actual Results:  
hppa-unknown-linux-gnu-gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"hppa"' -DCONF_OSTYPE='"linux-gnu"' -DCONF_MACHTYPE='"hppa-unknown-linux-gnu"' -DCONF_VENDOR='"unknown"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib  -DDEFAULT_PATH_VALUE='"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"' -DSTANDARD_UTILS_PATH='"/bin:/usr/bin:/sbin:/usr/sbin"' -DSYS_BASHRC='"/etc/bash/bashrc"' -DSYS_BASH_LOGOUT='"/etc/bash/bash_logout"' -DNON_INTERACTIVE_LOGIN_SHELLS -DSSH_SOURCE_BASHRC -Os -pipe  -fomit-frame-pointer -I/usr/hppa-unknown-linux-gnu/usr/include/ -I/usr/hppa-unknown-linux-gnu/include/ -c version.c
execute_cmd.c: In function ‘execute_in_subshell’:
execute_cmd.c:1507:5: warning: passing argument 1 of ‘execute_command_internal’ discards qualifiers from pointer target type
execute_cmd.c:522:1: note: expected ‘struct COMMAND *’ but argument is of type ‘volatile struct COMMAND *’
execute_cmd.c: In function ‘execute_pipeline’:
execute_cmd.c:2205:23: error: ‘job_control’ undeclared (first use in this function)
execute_cmd.c:2205:23: note: each undeclared identifier is reported only once for each function it appears in
execute_cmd.c: In function ‘execute_function’:
execute_cmd.c:4243:3: warning: passing argument 1 of ‘array_rshift’ discards qualifiers from pointer target type
array.h:56:12: note: expected ‘struct ARRAY *’ but argument is of type ‘volatile struct ARRAY *’
execute_cmd.c:4245:3: warning: passing argument 1 of ‘array_rshift’ discards qualifiers from pointer target type
array.h:56:12: note: expected ‘struct ARRAY *’ but argument is of type ‘volatile struct ARRAY *’
execute_cmd.c:4320:3: warning: passing argument 1 of ‘array_shift’ discards qualifiers from pointer target type
array.h:55:23: note: expected ‘struct ARRAY *’ but argument is of type ‘volatile struct ARRAY *’
execute_cmd.c:4321:3: warning: passing argument 1 of ‘array_shift’ discards qualifiers from pointer target type
array.h:55:23: note: expected ‘struct ARRAY *’ but argument is of type ‘volatile struct ARRAY *’
make[1]: Wejście do katalogu `/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/work/bash-4.2/builtins'
rm -f builtins.o
hppa-unknown-linux-gnu-gcc -c  -DHAVE_CONFIG_H -DSHELL  -I. -I..  -I.. -I../include -I../lib -I.   -DDEFAULT_PATH_VALUE='"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"' -DSTANDARD_UTILS_PATH='"/bin:/usr/bin:/sbin:/usr/sbin"' -DSYS_BASHRC='"/etc/bash/bashrc"' -DSYS_BASH_LOGOUT='"/etc/bash/bash_logout"' -DNON_INTERACTIVE_LOGIN_SHELLS -DSSH_SOURCE_BASHRC -Os -pipe  -fomit-frame-pointer -I/usr/hppa-unknown-linux-gnu/usr/include/ -I/usr/hppa-unknown-linux-gnu/include/ builtins.c
make: *** [execute_cmd.o] Błąd 1
make: *** Oczekiwanie na niezakończone zadania....
rm -f alias.o

<...>


make[1]: Opuszczenie katalogu `/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/work/bash-4.2/builtins'
emake failed
 * ERROR: app-shells/bash-4.2_p10 failed (compile phase):
 *   make failed
 * 
 * Call stack:
 *     ebuild.sh, line  91:  Called src_compile
 *   environment, line 2620:  Called die
 * The specific snippet of code:
 *       emake || die "make failed";
 * 
 * If you need support, post the output of 'emerge --info =app-shells/bash-4.2_p10',
 * the complete build log and the output of 'emerge -pqv =app-shells/bash-4.2_p10'.
 * The complete build log is located at '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/temp/build.log'.
 * The ebuild environment file is located at '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/temp/environment'.
 * S: '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/work/bash-4.2'

>>> Failed to emerge app-shells/bash-4.2_p10 for /usr/hppa-unknown-linux-gnu/, Log file:

>>>  '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/temp/build.log'

 * Messages for package app-shells/bash-4.2_p10 merged to /usr/hppa-unknown-linux-gnu/:

 * ERROR: app-shells/bash-4.2_p10 failed (compile phase):
 *   make failed
 * 
 * Call stack:
 *     ebuild.sh, line  91:  Called src_compile
 *   environment, line 2620:  Called die
 * The specific snippet of code:
 *       emake || die "make failed";
 * 
 * If you need support, post the output of 'emerge --info =app-shells/bash-4.2_p10',
 * the complete build log and the output of 'emerge -pqv =app-shells/bash-4.2_p10'.
 * The complete build log is located at '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/temp/build.log'.
 * The ebuild environment file is located at '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/temp/environment'.
 * S: '/usr/hppa-unknown-linux-gnu/tmp/portage/app-shells/bash-4.2_p10/work/bash-4.2'

 * IMPORTANT: 1 news items need reading for repository 'gentoo'.
 * Use eselect news to read news items.


Expected Results:  
Success in compiling bash.

kraken portage # hppa-unknown-linux-gnu-emerge --info
PORTAGE_BZIP2_COMMAND setting is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting from make.globals is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting from make.globals is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting from make.globals is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting is invalid: 'bzip2'
PORTAGE_BZIP2_COMMAND setting from make.globals is invalid: 'bzip2'
FEATURES variable contains unknown value(s): autopatch
Portage 2.1.10.16 (default/linux/hppa/10.0, gcc-4.5.3, unavailable, 3.0.3-kraken x86_64)
=================================================================
System uname: Linux-3.0.3-kraken-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T7300_@_2.00GHz-with-gentoo-2.0.3
Timestamp of tree: Wed, 14 Sep 2011 19:15:01 +0000
app-shells/bash:          4.2_p10::<unknown repository>
dev-java/java-config:     2.1.11-r3::<unknown repository>
dev-lang/python:          2.4.6::<unknown repository>, 2.5.4-r4::<unknown repository>, 2.6.7-r2::<unknown repository>, 2.7.2-r2::<unknown repository>, 3.1.4-r2::<unknown repository>, 3.2-r2::<unknown repository>
dev-util/cmake:           2.8.5-r2::<unknown repository>
dev-util/pkgconfig:       0.26::<unknown repository>
sys-apps/baselayout:      2.0.3::<unknown repository>
sys-apps/openrc:          0.9.3-r1::<unknown repository>
sys-apps/sandbox:         2.5::<unknown repository>
sys-devel/autoconf:       2.13::<unknown repository>, 2.68::<unknown repository>
sys-devel/automake:       1.5-r1::<unknown repository>, 1.7.9-r2::<unknown repository>, 1.8.5-r4::<unknown repository>, 1.9.6-r3::<unknown repository>, 1.10.3::<unknown repository>, 1.11.1-r1::<unknown repository>
sys-devel/binutils:       2.21.1-r1::<unknown repository>
sys-devel/gcc:            4.5.3-r1::<unknown repository>
sys-devel/gcc-config:     1.4.1-r1::<unknown repository>
sys-devel/libtool:        2.4-r1::<unknown repository>
sys-devel/make:           3.82-r1::<unknown repository>
sys-kernel/linux-headers: 2.6.39::<unknown repository> (virtual/os-headers)
sys-libs/glibc:           2.13-r4::<unknown repository>
Repositories: gentoo
ACCEPT_KEYWORDS="hppa ~hppa"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-Os -pipe  -fomit-frame-pointer -I/usr/hppa-unknown-linux-gnu/usr/include/ -I/usr/hppa-unknown-linux-gnu/include/"
CHOST="hppa-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-Os -pipe  -fomit-frame-pointer -I/usr/hppa-unknown-linux-gnu/usr/include/ -I/usr/hppa-unknown-linux-gnu/include/"
DISTDIR="/var/cache/src"
FEATURES="assume-digests autopatch binpkg-logs buildpkg distlocks ebuild-locks fixlafiles fixpackages news nodoc noinfo noman parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://gentoo.mirror.pw.edu.pl"
LANG="pl_PL.utf8"
LDFLAGS="-L/usr/hppa-unknown-linux-gnu/lib -L/usr/hppa-unknown-linux-gnu/usr/lib"
MAKEOPTS="-j3"
PKGDIR="/usr/hppa-unknown-linux-gnu/packages/"
PORTAGE_CONFIGROOT="/usr/hppa-unknown-linux-gnu/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/usr/hppa-unknown-linux-gnu/tmp/"
PORTDIR="/var/cache/ebuild/gentoo"
PORTDIR_OVERLAY="/var/cache/ebuild/bitcoin /var/cache/ebuild/cpan /var/cache/ebuild/crossdev /var/cache/ebuild/dropzone /var/cache/ebuild/gnome /var/cache/ebuild/kde /var/cache/ebuild/nokia-siemens-networks /var/cache/ebuild/sunrise /var/cache/ebuild/x11"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="berkdb bindist bzip2 cli cracklib crypt cups cxx firefox foomaticdb fortran gdbm gpm hppa iconv imlib ipv6 libwww make-symlinks minimal modules mudflap ncurses nls nptl nptlonly openmp pam pcre perl pppd python readline session spell ssl sysfs tcpd unicode xml2 xorg xulrunner zlib" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev dummy" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Maciej Grela 2011-09-16 14:34:04 UTC]

Created attachment 286677 [details, diff]
Add JOB_CONTROL #ifdef to fix cross-compilation.

[Comment 2 SpanKY 2011-09-16 17:25:48 UTC]

should be all set now in the tree; thanks for the report!

Commit message: Fix building when job controls are disabled (like when cross-compiling)
http://sources.gentoo.org/app-shells/bash/bash-4.2_p10.ebuild?r1=1.3&r2=1.4
http://sources.gentoo.org/app-shells/bash/files/bash-4.2-execute-job-control.patch?rev=1.1