Bug 383033

Summary:	dev-util/qt-creator bundles a copy of dev-libs/libbotan
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Markos Chandras (RETIRED) <hwoarang>
Status:	RESOLVED FIXED
Severity:	normal	CC:	qa, qt, realnc
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	383065
Bug Blocks:	251464

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2011-09-15 06:50:49 UTC

It is named libBotan rather than libbotan but it exposes the same symbols.. is it possible to simply drop it and make it use a system copy, please?

Comment 1 Markos Chandras (RETIRED) gentoo-dev

2011-09-15 10:40:20 UTC

Hmm. Interesting. qt-creator fails to build with botan-1.10.1 so it needs to hardcode 1.8.* version. Even if I don't like forcing users to use a specific version, this is the right way to go

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2011-09-15 12:04:57 UTC

An initial ebuild was pushed to qting-edge overlay for further testing

Comment 3 Davide Pesavento (RETIRED) gentoo-dev

2011-09-15 12:05:46 UTC

Have you checked that they didn't modify the bundled copy?

Comment 4 Markos Chandras (RETIRED) gentoo-dev

2011-09-15 12:25:47 UTC

(In reply to comment #3)
There is no reference in src/lib/3rdparty/botan that the original 1.8 source is modified so I took it for granted that the bundled copy has not been modified.

Comment 5 Nikos Chantziaras 2011-09-15 13:41:40 UTC

dev-libs/botan is not slotted, so I'm not sure how this is supposed to work.  I need 1.10, not 1.8.

Comment 6 Markos Chandras (RETIRED) gentoo-dev

2011-09-15 14:00:41 UTC

(In reply to comment #5)
It's not gonna work. qt-creator requires 1.8 and it does not build with 1.10. I am considering a useflag to control whether you want the bundled copy or not. Diego+QA, do you think a useflag for this purpose is acceptable?

Comment 7 Davide Pesavento (RETIRED) gentoo-dev

2011-09-15 16:11:50 UTC

Or maybe we should consider slotting libbotan...?

Comment 8 Markos Chandras (RETIRED) gentoo-dev

2011-09-15 16:15:51 UTC

(In reply to comment #7)
There are lot of packages using useflags to choose between bundled and system libraries. I guess we can do the same for qt-creator for now. Whether botan can be slotted or not is not our job. We can open a bug requesting botan slotting though

Comment 9 Diego Elio Pettenò (RETIRED) gentoo-dev

2011-09-15 16:27:32 UTC

How difficult would it be to support botan 1.10?

Comment 10 Markos Chandras (RETIRED) gentoo-dev

2011-09-15 16:46:30 UTC

(In reply to comment #9)
Seems like the API has changed between 1.8 and 1.10 so I presume it requires source code modifications in qt-creator to match the latest API. I am not sure how easy or hard will that be.

Comment 11 Markos Chandras (RETIRED) gentoo-dev

2011-09-21 10:13:06 UTC

The modified ebuild was moved to portage. I will use botan-bundled for now until I find sometime to see if the botan-1.10 API can be used in qt-creator. Thanks for reporting