| Summary: | dev-util/debhelper: please review prefix changes | ||
|---|---|---|---|
| Product: | Gentoo/Alt | Reporter: | yegle <cnyegle> |
| Component: | Prefix Support | Assignee: | Debian-related package maintainers [DISBANDED] <deb-tools+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | prefix |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://anonscm.debian.org/gitweb/?p=debhelper/debhelper.git;a=commit;h=0aa572f1de498231683a555341841d582d813f21 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 315803 | ||
| Attachments: |
build.log
emerge --info =dev-util/debhelper-8.9.3 patch for debhelper-9.20120608.ebuild patch for debhelper-9.20120608.ebuild |
||
Created attachment 286371 [details]
build.log
Created attachment 286373 [details]
emerge --info =dev-util/debhelper-8.9.3
debhelper is not keyworded which means that it was never tested/ported to Gentoo Prefix Please post a diff between your ebuild and the one from gx. Created attachment 322126 [details]
patch for debhelper-9.20120608.ebuild
The main problem is that /usr is hard coded in the makefile, but PERLLIBDIR not.
default calls "emake DESTDIR=${D}", which will install the scripts outside of the prefix. "emake DESTDIR=${ED}" would fix that, but then the perl stuff is double prefixed as PERLLIBDIR already contains EPREFIX.
Comment on attachment 322126 [details]
patch for debhelper-9.20120608.ebuild
please attach a unified diff
Created attachment 322130 [details, diff]
patch for debhelper-9.20120608.ebuild
Wrong file.
I just realized:
eval "$(perl -V:installvendorlib )"
emake install DESTDIR="${ED}" \
PERLLIBDIR="${installvendorlib#${EPREFIX}}/Debian/Debhelper"
instead of default would also work.
A patch to support prefix got merged upstream, so things should be easy after the next release. + 18 Jun 2013; Christoph Junghans <ottxor@gentoo.org> + debhelper-9.20130605.ebuild: + added prefix support (bug #382849) |
debhelper failed to install due to QA concerns. Seems like a bug in the QA check code? These files listed are indeed installed inside the prefix. Code in Makefile: install: install -d $(DESTDIR)/usr/bin \ $(DESTDIR)/usr/share/debhelper/autoscripts \ $(DESTDIR)$(PERLLIBDIR)/Sequence \ $(DESTDIR)$(PERLLIBDIR)/Buildsystem install dh $(COMMANDS) $(DESTDIR)/usr/bin install -m 0644 autoscripts/* $(DESTDIR)/usr/share/debhelper/autoscripts install -m 0644 Debian/Debhelper/*.pm $(DESTDIR)$(PERLLIBDIR) install -m 0644 Debian/Debhelper/Sequence/*.pm $(DESTDIR)$(PERLLIBDIR)/Sequence install -m 0644 Debian/Debhelper/Buildsystem/*.pm $(DESTDIR)$(PERLLIBDIR)/Buildsystem Reproducible: Always