Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 382685

Summary: gnome-base/gnome-session: 10-user-dirs-update installed to /etc/X11/xinit/xinitrc.d/
Product: Gentoo Linux Reporter: Samuli Suominen (RETIRED) <ssuominen>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: QA CC: xfce
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 270852    

Description Samuli Suominen (RETIRED) gentoo-dev 2011-09-12 10:18:28 UTC
gnome-session is mistakenly adding 10-user-dirs-update to /etc/X11/xinit/xinitrc.d/ causing xdg-user-dirs-update to be executed twice on Xfce startup:

- once by upstream Xfce, startxfce4 script
- once by accident, from xinitrc.d, if gnome-session *happens* to be installed

Obviously this is not the package that should install the file if executed unconditionally even if not running GNOME, it should be guarded by some check for GNOME, or the file shouldn't be installed by gnome-session at all...

(Please don't repeat the GDM mistake by adding random files there, yet to file a bug about that...)
Comment 1 Pacho Ramos gentoo-dev 2011-09-12 10:20:28 UTC
I can move this to xdg-users-dirs packages as all other major distributions are doing already (like fedora, opensuse, mandriva...), are you ok?
Comment 2 Pacho Ramos gentoo-dev 2011-09-12 10:21:00 UTC
This needs to be done with xfce team also I think ;)
Comment 3 Pacho Ramos gentoo-dev 2011-09-12 10:26:00 UTC
Umm, sorry for the misunderstanding, looks like upstream xfce already runs it at their own, in that case I think we should modify a bit xinitrc.d file to only run when [ "$DESKTOP_SESSION" = "gnome" ] (like it's done in 10-xdg-menu-gnome)
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-09-12 10:29:22 UTC
(In reply to comment #3)
> Umm, sorry for the misunderstanding, looks like upstream xfce already runs it
> at their own, in that case I think we should modify a bit xinitrc.d file to
> only run when [ "$DESKTOP_SESSION" = "gnome" ] (like it's done in
> 10-xdg-menu-gnome)

yeah, since xdg-user-dirs doesn't provide autostart file, Xfce upstream decided to run it on their own. I think this is correct approach and I don't want to alter that against upstream in Xfce packages.

Please change the name to something like 10-user-dirs-update-gnome and guard it with that [ "$DESKTOP_SESSION" = "gnome" ]
Comment 5 Pacho Ramos gentoo-dev 2011-09-12 10:36:46 UTC
+  12 Sep 2011; Pacho Ramos <pacho@gentoo.org> +files/10-user-dirs-update-gnome,
+  -files/10-user-dirs-update, gnome-session-2.32.1-r3.ebuild,
+  gnome-session-3.0.2.ebuild:
+  Only run xdg-user-dirs-update under Gnome to prevent conflicts with XFCE, bug
+  #382685 by Samuli Suominen.
+

I finally didn't revbumped for this change as 3.0.2 is hardmasked and 2.32.1-r3 was released only a few minutes ago... but, if you want to be stricter, let me know and will revbump if have enough time :)

Thanks for noticing the problem